Windows 7 + Virtual terminal
Summary
It's very nice that you fixed colored output on Windows, but Windows 7 doesn't support flag ENABLE_VIRTUAL_TERMINAL_PROCESSING. Probably, function InitCli() must check windows version.
Steps to reproduce
- run gitlab-runner.11.10.1.exe on Windows 7
- check output
$ gitlab-runner.exe status
time="2019-04-25T08:58:07+03:00" level=info msg="Failed to set console mode for cli" error="The parameter is incorrect."
time="2019-04-25T08:58:07+03:00" level=info msg="Failed to set console mode for cli" error="The parameter is incorrect."
Runtime platform arch=386 os=windows pid=7912 revision=1f513601 version=11.10.1
gitlab-runner: Service is running!
Environment description
Windows 7 x86_32
Used GitLab Runner version
$ gitlab-runner.exe --version
time="2019-04-25T09:01:29+03:00" level=info msg="Failed to set console mode for cli" error="The parameter is incorrect."
time="2019-04-25T09:01:29+03:00" level=info msg="Failed to set console mode for cli" error="The parameter is incorrect."
Version: 11.10.1
Git revision: 1f513601
Git branch: 11-10-stable
GO version: go1.8.7
Built: 2019-04-24T09:29:09+0000
OS/Arch: windows/386