Follow-up from "Add docker support for interactive web terminal"
The following discussion from !1008 (merged) should be addressed:
-
@tmaczukin started a discussion: (+1 comment) - Empty line
- This test have no action. There is
MockClient
created,commandExecutor
configured, some operations mocked. But there is nothing that's being executed here.
-
@tmaczukin started a discussion: @ayufan @SteveAzz I've left one comment. I also see that in many places we're using mocks, but no
defer XXX.AssertExpectations(t)
is called. I took only a quick look, but least in some places it should be called to make the test fully reliable.My proposition is to merge this MR, and then improve testing in a follow-up.
Edited by Steve Xuereb