assert.Equal wrong parameter order

Summary

A bunch of assert.Equal calls in tests have the wrong parameter order

> go doc assert.Equal
package assert // import "gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/stretchr/testify/assert"

func Equal(t TestingT, expected, actual interface{}, msgAndArgs ...interface{}) bool

Steps to reproduce

n.a.

Actual behavior

assert.Equal(t, x.Key, "FOO") If test fails prints:

Not equal:
expected: <x.Key>
actual: "FOO"

Expected behavior

assert.Equal(t, "FOO", x.Key) If test fails prints:

Not equal:
expected: "FOO"
actual: <x.Key>

Relevant logs and/or screenshots

Output of git grep assert.Equal reduced to the lines where i think expected and actual value are swapped.

commands/helpers/cache_archiver_test.go:    assert.Equal(t, fi.ModTime(), fi2.ModTime(), "archive is up to date")
commands/helpers/retry_helper_test.go:  assert.Equal(t, r.Retry+1, retryCount)
commands/helpers/retry_helper_test.go:  assert.Equal(t, 1, retryCount)
common/variables_test.go:   assert.Equal(t, x.Key, "FOO")
common/variables_test.go:   assert.Equal(t, x.Value, "bar")
common/variables_test.go:   assert.Equal(t, x.Public, true)
common/variables_test.go:   assert.Equal(t, x.Internal, false) // cannot be set from the network
common/variables_test.go:   assert.Equal(t, x.File, true)
common/variables_test.go:   assert.Equal(t, expanded.Get("key"), "value_of_value_of_$undefined")
common/variables_test.go:   assert.Equal(t, expanded.Get("public"), "value_of_")
common/variables_test.go:   assert.Equal(t, expanded.Get("private"), "value_of_value_of_$undefined")
common/variables_test.go:   assert.Equal(t, expanded.ExpandValue("${public} ${private}"), "value_of_ value_of_value_of_$undefined")
common/variables_test.go:   assert.Equal(t, expanded.Get("key"), "$")
common/variables_test.go:   assert.Equal(t, expanded.Get("key2"), "/dsa")
common/variables_test.go:   assert.Equal(t, expanded.Get("key3"), "aabb")
common/variables_test.go:   assert.Equal(t, expanded.Get("key4"), "aabb")
executors/docker/executor_docker_test.go:   assert.Equal(t, device.PathOnHost, "/dev/kvm")
executors/docker/executor_docker_test.go:   assert.Equal(t, device.PathInContainer, "/dev/kvm")
executors/docker/executor_docker_test.go:   assert.Equal(t, device.CgroupPermissions, "rwm")
executors/docker/executor_docker_test.go:   assert.Equal(t, device.PathOnHost, "/dev/kvm")
executors/docker/executor_docker_test.go:   assert.Equal(t, device.PathInContainer, "/devices/kvm")
executors/docker/executor_docker_test.go:   assert.Equal(t, device.CgroupPermissions, "rwm")
executors/docker/executor_docker_test.go:   assert.Equal(t, device.PathOnHost, "/dev/kvm")
executors/docker/executor_docker_test.go:   assert.Equal(t, device.PathInContainer, "/devices/kvm")
executors/docker/executor_docker_test.go:   assert.Equal(t, device.CgroupPermissions, "r")
executors/kubernetes/executor_kubernetes_test.go:               assert.Equal(t, pod.Spec.Containers[0].Name, "build")
executors/kubernetes/executor_kubernetes_test.go:               assert.Equal(t, pod.Spec.Containers[0].Image, "test-image")
executors/kubernetes/executor_kubernetes_test.go:               assert.Equal(t, pod.Spec.Containers[0].Command, []string{"/init", "run"})
executors/kubernetes/executor_kubernetes_test.go:               assert.Equal(t, pod.Spec.Containers[1].Name, "helper")
executors/kubernetes/executor_kubernetes_test.go:               assert.Equal(t, pod.Spec.Containers[1].Image, "custom/helper-image")
executors/kubernetes/executor_kubernetes_test.go:               assert.Equal(t, pod.Spec.Containers[2].Name, "svc-0")
executors/kubernetes/executor_kubernetes_test.go:               assert.Equal(t, pod.Spec.Containers[2].Image, "test-service")
executors/kubernetes/executor_kubernetes_test.go:               assert.Equal(t, pod.Spec.Containers[2].Command, []string{"/init", "run"})
executors/kubernetes/executor_kubernetes_test.go:               assert.Equal(t, pod.Spec.Containers[2].Args, []string{"application", "--debug"})
helpers/service/simple_test.go: assert.Equal(t, err, errExample)
network/gitlab_test.go: assert.Equal(t, c.getLastUpdate(&noJobsToken.RunnerCredentials), "a nice timestamp", "Last-Update should be set")

Environment description

go version go1.10 linux/amd64

Used GitLab Runner version

commit-id: 80b03db9