clear-docker-cache do not clean all dangling images
Summary
I have a lot of dangling images in my system.
docker image ls
REPOSITORY TAG IMAGE ID CREATED SIZE
timbru31/node-chrome 16-alpine 9ff97ee9a487 11 hours ago 523MB
registry.gitlab.com/security-products/gemnasium 3 091ea9ac607b 15 hours ago 809MB
timbru31/node-chrome <none> c6f34fab08d3 35 hours ago 523MB
registry.gitlab.com/security-products/gemnasium <none> 7545b87b551b 39 hours ago 809MB
timbru31/node-chrome <none> e6daf9c72e6a 2 days ago 523MB
registry.gitlab.com/security-products/gemnasium <none> d69625ef0c7d 2 days ago 809MB
timbru31/node-chrome <none> 0d58b3c8db63 4 days ago 523MB
registry.gitlab.com/security-products/gemnasium <none> 1a13629ee766 4 days ago 809MB
this one for example :
docker image inspect d69625ef0c7d
[
{
"Id": "sha256:d69625ef0c7d1bf48ffea24967ff92f70577452d203563fe382dff76849c9019",
"RepoTags": [],
"RepoDigests": [
"registry.gitlab.com/security-products/gemnasium@sha256:0b6705510194622e5aa09344de702eea3ba045ad4efbeb4e80fa714411675a86"
],
"Parent": "",
"Comment": "",
"Created": "2022-12-25T04:10:53.388287466Z",
"Container": "0aab471ff50b837cf7dae2d222eb108757056cd35de6f7196356248462b1415a",
"ContainerConfig": {
"Hostname": "0aab471ff50b",
"Domainname": "",
"User": "",
"AttachStdin": false,
"AttachStdout": false,
"AttachStderr": false,
"Tty": false,
"OpenStdin": false,
"StdinOnce": false,
"Env": [
"PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
"NODE_VERSION=16.19.0",
"YARN_VERSION=1.22.19",
"RETIRE_JS_VERSION=3.0.7",
"GEMNASIUM_RETIREJS_JS_ADVISORY_DB=/jsrepository.json",
"VRANGE_DIR=/vrange",
"GEMNASIUM_DB_LOCAL_PATH=/gemnasium-db",
"GEMNASIUM_DB_REMOTE_URL=https://gitlab.com/gitlab-org/security-products/gemnasium-db.git",
"GEMNASIUM_DB_WEB_URL=https://gitlab.com/gitlab-org/security-products/gemnasium-db",
"GEMNASIUM_DB_REF_NAME=master",
"HOME=/tmp"
],
"Cmd": [
"/bin/sh",
"-c",
"#(nop) ",
"CMD [\"/analyzer\" \"run\"]"
],
"Image": "sha256:785684496d734fbe7361e3558b8b01f9c82defdf3e1fe81eea1a2aab8c9d1e83",
"Volumes": null,
"WorkingDir": "",
"Entrypoint": null,
"OnBuild": null,
"Labels": {}
},
"DockerVersion": "20.10.22",
"Author": "",
"Config": {
"Hostname": "",
"Domainname": "",
"User": "",
"AttachStdin": false,
"AttachStdout": false,
"AttachStderr": false,
"Tty": false,
"OpenStdin": false,
"StdinOnce": false,
"Env": [
"PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
"NODE_VERSION=16.19.0",
"YARN_VERSION=1.22.19",
"RETIRE_JS_VERSION=3.0.7",
"GEMNASIUM_RETIREJS_JS_ADVISORY_DB=/jsrepository.json",
"VRANGE_DIR=/vrange",
"GEMNASIUM_DB_LOCAL_PATH=/gemnasium-db",
"GEMNASIUM_DB_REMOTE_URL=https://gitlab.com/gitlab-org/security-products/gemnasium-db.git",
"GEMNASIUM_DB_WEB_URL=https://gitlab.com/gitlab-org/security-products/gemnasium-db",
"GEMNASIUM_DB_REF_NAME=master",
"HOME=/tmp"
],
"Cmd": [
"/analyzer",
"run"
],
"Image": "sha256:785684496d734fbe7361e3558b8b01f9c82defdf3e1fe81eea1a2aab8c9d1e83",
"Volumes": null,
"WorkingDir": "",
"Entrypoint": null,
"OnBuild": null,
"Labels": null
},
"Architecture": "amd64",
"Os": "linux",
"Size": 808585970,
"VirtualSize": 808585970,
"GraphDriver": {
"Data": {
"LowerDir": "/var/lib/docker/overlay2/489c91759ecf14202a65f95901ffaface6b50e9efc5166c0e9300b5afdaf403c/diff:/var/lib/docker/overlay2/7c7a0d1a2f2475f521c36120489eef1a29e94df4dfc289680391c677ee11411b/diff:/var/lib/docker/overlay2/a5d536c97f8d0fb9bea47f04c8dfe6d2e168e4bcd02df19376f5112d4ace5663/diff:/var/lib/docker/overlay2/33a432324b53dbd023f92c1d572846a3ca4e0dbc3818e8f163754b3bdfbeb2a8/diff:/var/lib/docker/overlay2/997df2512a859bf080525bbc2611b8106aa3ee2daad6dbc7b5eb6ea9da38361e/diff:/var/lib/docker/overlay2/b4f984c92c8e09e2165599de7a8d8e9196a0e77616e23eb54c9aa7ac07b77311/diff:/var/lib/docker/overlay2/c8704e7837f10556eb55739b6407b67fcaad7e02b61bf9c156cca87541476382/diff",
"MergedDir": "/var/lib/docker/overlay2/f510d4246ebbcf2035d5dcedffdfcf7200b6f0da36670f8e3263d1b38503405b/merged",
"UpperDir": "/var/lib/docker/overlay2/f510d4246ebbcf2035d5dcedffdfcf7200b6f0da36670f8e3263d1b38503405b/diff",
"WorkDir": "/var/lib/docker/overlay2/f510d4246ebbcf2035d5dcedffdfcf7200b6f0da36670f8e3263d1b38503405b/work"
},
"Name": "overlay2"
},
"RootFS": {
"Type": "layers",
"Layers": [
"sha256:e5e13b0c77cbb769548077189c3da2f0a764ceca06af49d8d558e759f5c232bd",
"sha256:fde94ab434f1d42f3e30d5426443d9c04092dee56b47c2a84e07b63d03acf77c",
"sha256:31dc8cd14d549f5b340409e96aea6303f2053475ba5a0f3eec32835d575a7e73",
"sha256:80f4fde5a0e9ce626ee38dffd4e9be641a7baa5c53f2b275271d98d072daca0e",
"sha256:791191804eb92281dd8072b0cb8704a2fc75378aef6396c4d6ac09b43ace1b50",
"sha256:ac6d7799ddd1aebf14bb6101b6a00219725dd8c6aaa325f4eac0419b8dcce5ea",
"sha256:2dc7773c80dbf7901624eab4fc72f16ef0760f73515a6e6eeb430aa7968f575c",
"sha256:58304ff2a20cc322a4e2f02e77892dc5cda2005b307872cc65e585f1bec548c0"
]
},
"Metadata": {
"LastTagTime": "0001-01-01T00:00:00Z"
}
}
]
Actual behavior
After sometimes I get a disk full. the clear-docker-cache do not his job. I run it once a day
Expected behavior
These images should be pruned.
Relevant logs and/or screenshots
I notice there is no label "managed.gitlab" in these images.
Possible fixes
The filter https://gitlab.com/gitlab-org/gitlab-runner/blob/main/packaging/root/usr/share/gitlab-runner/clear-docker-cache#L19 may not catch images.