Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gitlab-runner gitlab-runner
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 2,478
    • Issues 2,478
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 122
    • Merge requests 122
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • gitlab-runnergitlab-runner
  • Issues
  • #28128
Closed
Open
Created Aug 10, 2021 by Arran Walker@ajwalkerMaintainer1 of 3 checklist items completed1/3 checklist items

Continuous masking of masked variables above 4KiB

Problem

In !2979 (merged), we introduced a fix for masked variables above 4KiB, but it involved sometimes tailing the end of the variable. We discovered this was not a breaking change, as the previous masking implementation would also occasionally reveal masked variables, but in full, at any length, based on how a log line could be split across multiple Write() calls non-deterministically.

Proposal:

Remove the phrase transform and reliance on text/transform which has an internal 4 KiB buffer. This can be done keeping track of how much of a phrase has been matched, instead of buffering the phrase until a match.

Additionally, explore a trie-based solution, but may be difficult because we need to mask over arbitary write boundaries.

Tasks

  • New masking solution: !3482
  • Conduct regression testing
  • Conduct performance testing
Edited Jun 09, 2022 by Arran Walker
Assignee
Assign to
Time tracking