Fix Windows tests in helpers/archive package
While working on fixing reporting of build failures for CI Windows tests, I noticed that some broken tests were currently hidden from view by a build error in this package. Here are the issues I've noticed so far:
-
TestZipCreate
does not build on Windows due to call to missingsyscall.Mkfifo
method; -
TestZipCreateWithGitPath
is failing a couple of assertions:--- FAIL: TestZipCreateWithGitPath (0.02s) zip_create_test.go:177: Error Trace: zip_create_test.go:177 zip_create_test.go:93 zip_create_test.go:149 Error: Not equal: expected: 0x1a0 actual : 0x1b6 Test: TestZipCreateWithGitPath zip_create_test.go:181: Error Trace: zip_create_test.go:181 zip_create_test.go:93 zip_create_test.go:149 Error: Not equal: expected: 0x1a0 actual : 0x1b6 Test: TestZipCreateWithGitPath
-
TestCreateZipExtra
is failing an assertion:--- FAIL: TestCreateZipExtra (0.00s) zip_extra_test.go:25: Error Trace: zip_extra_test.go:25 Error: "UT��&R`" should have 24 item(s), but has 9 Test: TestCreateZipExtra
Edited by Pedro Pombeiro