Job trace limit exceeded regression in 13.9.0-rc1
Recently merged !2677 (merged) has introduced another regression related to how job trace limit is handled.
Job output is collected by GitLab Runner and passed to GitLab. But for operational reasons the size of the collected output is limited. By default it's 4 MiB and it can be set to custom value in config.toml
file.
The behavior of output limiting is that when the limit is exceeded, a warning message is printed and output collection is finished. The job however should continue to be executed and the final status - whether it's success, failure or cancel of the job - should be handled as usual.
The MR linked above unfortunately have changed this. With it when the job output limit is exceeded, the job fails immediately. This is wrong, it's a behavior change and because of that it's a ~bug and a %13.9 regression.
We should revert the change (it's already handled in context of another regression: #27559 (closed)) and add integration tests that will guard that a valid behavior is preserved in future.