Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
gitlab-runner
gitlab-runner
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1,996
    • Issues 1,996
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 204
    • Merge Requests 204
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • gitlab-runnergitlab-runner
  • Issues
  • #26996

Closed
Open
Opened Sep 23, 2020 by Arran Walker@ajwalkerDeveloper

Error cleaning up secrets: resource name may not be empty

Description

The Kubernetes executor's setupCredentials function creates a new secret with docker repository credentials:

	s.credentials, err = s.kubeClient.CoreV1().Secrets(s.configurationOverwrites.namespace).Create(&secret)
	if err != nil {
		return err
	}

Unfortunetly, when creating a secret, if an error is encountered, an empty resource object is still returned.

Later, in cleanupResources, we check that the credential exists and try to delete it:

	if s.credentials != nil {
		// s.kubeClient.CoreV1().Delete etc...
	}

This causes an additional error, because we're trying to delete a resource that technically doesn't exist:

image

Proposal

Only set s.credentials when Create() on the secret succeeds.

Edited Sep 23, 2020 by Arran Walker
Assignee
Assign to
13.7
Milestone
13.7 (Past due)
Assign milestone
Time tracking
None
Due date
None
Reference: gitlab-org/gitlab-runner#26996