Validate that all steps execute in integration tests
This is a follow-up issue from #25425 (closed).
In #25425 (closed) we validated that before_script
, script
, after_script
are run during integration tests.
We now need to validate that all steps are executed, for example:
- git clone
- artifact download
- cache download
- script
- after_script
- artifact upload
- cache upload
Proposal
Update TestDockerCommandMultistepBuild
to validate all the steps mentioned above, or write a new test specifically to for this, for example add a new test TestDockerCommandValidateStepsExecution
.
The following discussion from !2211 (merged) should be addressed:
-
@steveazz started a discussion: (+1 comment) I removed the
closes https://gitlab.com/gitlab-org/gitlab-runner/-/issues/25425
part because in #25425 (closed) we need to validate that all steps execute, so, for example, we need to make suregit clone
,download cache
,download artifacts
,script_step
,after_script
,upload cache
,upload artifacts
get run not just the build script and the after script