Follow-up from "Replace Code Climate with golangci-lint"
The following discussion from !1956 (merged) should be addressed:
-
@ggeorgiev_ started a discussion: (+5 comments) @steveazz @pedropombeiro @lraykov You did a great job merging all these changes
❤ I have been skimming through them and this caught my eye. I think we should be able to make the decision between performance and readability ourselves. In this case, the mental gymnastics of following the slice capacity in this method is too much IMO. 99% of the time initializing a
nil
slice is all the same for us since it incurs just one or two allocations anyways. What do you think🤔