Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
What's new
6
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Switch to GitLab Next
Sign in / Register
Toggle navigation
gitlab-runner
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Locked Files
Issues
1,989
Issues
1,989
List
Boards
Labels
Service Desk
Milestones
Iterations
Merge Requests
189
Merge Requests
189
Requirements
Requirements
List
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Test Cases
Security & Compliance
Security & Compliance
Dependency List
License Compliance
Operations
Operations
Incidents
Environments
Packages & Registries
Packages & Registries
Container Registry
Analytics
Analytics
CI / CD
Code Review
Insights
Issue
Repository
Value Stream
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
GitLab.org
gitlab-runner
Commits
4fb92ffd
Verified
Commit
4fb92ffd
authored
Jul 25, 2016
by
Tomasz Maczukin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Log response status while handling artifacts only when response <> nil
parent
0277ff77
Pipeline
#3781998
passed with stage
in 10 minutes and 51 seconds
Changes
2
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
13 additions
and
3 deletions
+13
-3
CHANGELOG.md
CHANGELOG.md
+3
-0
network/gitlab.go
network/gitlab.go
+10
-3
No files found.
CHANGELOG.md
View file @
4fb92ffd
...
...
@@ -15,6 +15,9 @@ v 1.4.0
-
Fix Absolute method for absolute path discovering for bash
-
Fix zombie issues by using dumb-init instead of github.com/ramr/go-reaper
v 1.3.4
-
Fix panic while artifacts handling errors
v 1.3.2
-
Fix architecture detection bug introduced in 1.3.1
...
...
network/gitlab.go
View file @
4fb92ffd
...
...
@@ -324,11 +324,14 @@ func (n *GitLabClient) UploadRawArtifacts(config common.BuildCredentials, reader
res
,
err
:=
n
.
doRaw
(
mappedConfig
,
"POST"
,
fmt
.
Sprintf
(
"builds/%d/artifacts?%s"
,
config
.
ID
,
query
.
Encode
()),
pr
,
mpw
.
FormDataContentType
(),
headers
)
log
:=
logrus
.
WithFields
(
logrus
.
Fields
{
"id"
:
config
.
ID
,
"token"
:
helpers
.
ShortenToken
(
config
.
Token
),
"responseStatus"
:
res
.
Status
,
"id"
:
config
.
ID
,
"token"
:
helpers
.
ShortenToken
(
config
.
Token
),
})
if
res
!=
nil
{
log
=
log
.
WithField
(
"responseStatus"
,
res
.
Status
)
}
if
err
!=
nil
{
log
.
WithError
(
err
)
.
Errorln
(
"Uploading artifacts to coordinator..."
,
"error"
)
return
common
.
UploadFailed
...
...
@@ -396,6 +399,10 @@ func (n *GitLabClient) DownloadArtifacts(config common.BuildCredentials, artifac
"token"
:
helpers
.
ShortenToken
(
config
.
Token
),
})
if
res
!=
nil
{
log
=
log
.
WithField
(
"responseStatus"
,
res
.
Status
)
}
if
err
!=
nil
{
log
.
Errorln
(
"Downloading artifacts from coordinator..."
,
"error"
,
err
.
Error
())
return
common
.
DownloadFailed
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment