Graphql field enums
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you receive complimentary access to GitLab Duo.
What does this MR do and why?
This MR aims to expand the use of GRAPQL field enums while reducing the use of plain strings.
Reference issue: #16
Merge request reports
Activity
Thanks for your contribution to GitLab @salihudickson!
Did you know about our community forks? Working from there will make your contribution process easier. Please check it out!
- If you need help, page a coach by clicking here or come say hi on Discord.
- When you're ready, request a review by clicking here.
- We welcome AI-generated contributions and offer complimentary access to GitLab Duo!
- To add labels to your merge request, comment
@gitlab-bot label ~"label1" ~"label2"
.
This message was generated automatically. Improve it or delete it.
added Community contribution workflowin dev labels
assigned to @salihudickson
added linked-issue label
@himkp, Can you please take a look at this. There are a few things I need you feedback on specifically;
- I added the remaining field enums from the haskell version, not sure how I did on some of the string representations, considering that some of them have been changed.
- I implemented a GRAPHQL field struct as you suggested, but i had to add a few implementations so that it could properly replace the
&str
variables that were being used. I hope that doesn't unnecessarily complicate the code. - Some of the fields being sent to the
wrap_nodes
andwrap_fields
functions as strings, don't have any similarly named field enums. I have left them as strings because I am not sure which, if any, of the field enums they translate to.
added 34 commits
-
95a92fd6...88abf106 - 29 commits from branch
gitlab-org/gitlab-query-language:main
- b4738234 - refactor: use enums for grapphql field names
- f2683e5b - chore: add missing field names in Field Enum
- 7ae18715 - refactor: replace plain strings with Field enums
- 8cc9387e - chore: lint code
- cc4e1976 - chore: fix errors from rebase
Toggle commit list-
95a92fd6...88abf106 - 29 commits from branch
mentioned in issue gitlab-org/quality/triage-reports#22006 (closed)
added glql label
added featureenhancement typefeature labels
added groupknowledge label
added devopsplan sectiondev labels
hey @himkp, just a quick follow up. Please share some feedback whenever you have the time.
Thanks @salihudickson for working on this. I am a bit behind on reviews. I will take a look before early next week.
@salihudickson, it seems we're waiting on an action from you for approximately two weeks.
- Do you still have capacity to work on this? If not, you might want to close this MR and/or ask someone to take over.
- Do you need help in getting it ready? At any time, you can:
- If you're actually ready for a review, you can post
@gitlab-bot ready
.
This message was generated automatically. You're welcome to improve it.
added automation:author-reminded label