Fix failures in ruby 3.2
Upon investigation of the failure noted in https://gitlab.com/gitlab-org/gitlab/-/jobs/6813629784 it appears that we have a number of places in gitlab-qa which are impacted by what look like breaking changes from ruby3.1
to ruby3.2
$ asdf shell ruby 3.1.5
$ bundle install
$ rspec
Finished in 0.26028 seconds (files took 1.35 seconds to load)
378 examples, 0 failures
$ asdf shell ruby 3.2.3
$ bundle install
$ rspec
Finished in 0.25165 seconds (files took 0.58975 seconds to load)
378 examples, 6 failures
Failed examples:
rspec ./spec/gitlab/qa/docker/engine_spec.rb:158 # Gitlab::QA::Docker::Engine#write_files with secrets to mask passes secrets to exec
rspec ./spec/gitlab/qa/docker/engine_spec.rb:166 # Gitlab::QA::Docker::Engine#write_files without secrets to mask does not pass any secrets to exec
rspec ./spec/gitlab/qa/docker/engine_spec.rb:24 # Gitlab::QA::Docker::Engine#exec without secrets to mask does not pass any secrets to Docker::Command
rspec ./spec/gitlab/qa/docker/engine_spec.rb:16 # Gitlab::QA::Docker::Engine#exec with secrets to mask passes secrets to Docker::Command
rspec ./spec/gitlab/qa/component/specs_spec.rb:408 # Gitlab::QA::Component::Specs#perform with retry enabled with failures in last run file retries failed specs
rspec ./spec/gitlab/qa/component/specs_spec.rb:432 # Gitlab::QA::Component::Specs#perform with retry enabled without failures in last run file does not retry failed specs
Edited by John McDonnell