Gitlab::QA::Support::GitlabUpgradePath fails for major 15.x release updates
As seen in https://gitlab.com/gitlab-org/gitlab/-/jobs/4739001735:
bundler: failed to load command: gitlab-qa (/builds/gitlab-org/gitlab/.gems/bin/gitlab-qa)
/builds/gitlab-org/gitlab/.gems/gems/gitlab-qa-10.3.0/lib/gitlab/qa/support/gitlab_upgrade_path.rb:33:in `<=': comparison of Gem::Version with nil failed (ArgumentError)
from /builds/gitlab-org/gitlab/.gems/gems/gitlab-qa-10.3.0/lib/gitlab/qa/support/gitlab_upgrade_path.rb:33:in `block in fetch'
from /builds/gitlab-org/gitlab/.gems/gems/gitlab-qa-10.3.0/lib/gitlab/qa/support/gitlab_upgrade_path.rb:32:in `each'
from /builds/gitlab-org/gitlab/.gems/gems/gitlab-qa-10.3.0/lib/gitlab/qa/support/gitlab_upgrade_path.rb:32:in `each_with_object'
from /builds/gitlab-org/gitlab/.gems/gems/gitlab-qa-10.3.0/lib/gitlab/qa/support/gitlab_upgrade_path.rb:32:in `fetch'
from /builds/gitlab-org/gitlab/.gems/gems/gitlab-qa-10.3.0/lib/gitlab/qa/scenario/test/omnibus/update_from_previous.rb:37:in `perform'
from /builds/gitlab-org/gitlab/.gems/gems/gitlab-qa-10.3.0/lib/gitlab/qa/scenario/template.rb:10:in `block in perform'
from <internal:kernel>:90:in `tap'
from /builds/gitlab-org/gitlab/.gems/gems/gitlab-qa-10.3.0/lib/gitlab/qa/scenario/template.rb:8:in `perform'
from /builds/gitlab-org/gitlab/.gems/gems/gitlab-qa-10.3.0/lib/gitlab/qa/runner.rb:96:in `run'
from /builds/gitlab-org/gitlab/.gems/gems/gitlab-qa-10.3.0/exe/gitlab-qa:9:in `<top (required)>'
from /builds/gitlab-org/gitlab/.gems/bin/gitlab-qa:25:in `load'
from /builds/gitlab-org/gitlab/.gems/bin/gitlab-qa:25:in `<top (required)>'
from /usr/local/lib/ruby/gems/3.0.0/gems/bundler-2.3.26/lib/bundler/cli/exec.rb:58:in `load'
from /usr/local/lib/ruby/gems/3.0.0/gems/bundler-2.3.26/lib/bundler/cli/exec.rb:58:in `kernel_load'
from /usr/local/lib/ruby/gems/3.0.0/gems/bundler-2.3.26/lib/bundler/cli/exec.rb:23:in `run'
from /usr/local/lib/ruby/gems/3.0.0/gems/bundler-2.3.26/lib/bundler/cli.rb:486:in `exec'
from /usr/local/lib/ruby/gems/3.0.0/gems/bundler-2.3.26/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
from /usr/local/lib/ruby/gems/3.0.0/gems/bundler-2.3.26/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
from /usr/local/lib/ruby/gems/3.0.0/gems/bundler-2.3.26/lib/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
from /usr/local/lib/ruby/gems/3.0.0/gems/bundler-2.3.26/lib/bundler/cli.rb:31:in `dispatch'
from /usr/local/lib/ruby/gems/3.0.0/gems/bundler-2.3.26/lib/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
from /usr/local/lib/ruby/gems/3.0.0/gems/bundler-2.3.26/lib/bundler/cli.rb:25:in `start'
from /usr/local/lib/ruby/gems/3.0.0/gems/bundler-2.3.26/exe/bundle:48:in `block in <top (required)>'
from /usr/local/lib/ruby/gems/3.0.0/gems/bundler-2.3.26/lib/bundler/friendly_errors.rb:120:in `with_friendly_errors'
from /usr/local/lib/ruby/gems/3.0.0/gems/bundler-2.3.26/exe/bundle:36:in `<top (required)>'
from /usr/local/bin/bundle:23:in `load'
from /usr/local/bin/bundle:23:in `<main>'
Running after_script
I can reproduce this via:
require_relative 'lib/gitlab/qa'
Gitlab::QA::Support::GitlabUpgradePath.new("15.11.0", "major", "ee").fetch
It seems the available versions
(as defined by https://registry.hub.docker.com/v2/namespaces/gitlab/repositories/gitlab-ee/tags?page_size=5000) only goes up from 15 and up?
/cc: @acunskis