Add QA_CAN_TEST_GIT_PROTOCOL_V2

Includes doc updates

docs/run_qa_against_gdk.md

@@ -4,13 +4,15 @@ To run the `Test::Instance::Any` scenario against your local GDK, you'll need to
 make a few changes to your `gdk/gitlab/config/gitlab.yml` file.
 
 1. Retrieve your current local IP with `ifconfig`, e.g. `192.168.0.12`.
-1. Edit `gdk/gitlab/config/gitlab.yml` and replace `host: localhost` with 
+1. Edit `gdk/gitlab/config/gitlab.yml` and replace `host: localhost` with
    `host: 192.168.0.12`.
-1. Also replace `ssh_host: localhost` (found under `gitlab_shell`) with 
+1. Also replace `ssh_host: localhost` (found under `gitlab_shell`) with
    `ssh_host: 192.168.0.12`.
-1. Enable the `sshd` service by uncommenting the relevant line in your 
+1. Enable the `sshd` service by uncommenting the relevant line in your
    `Procfile`.
-1. Edit `openssh/sshd_config` and set `ListenAddress` to `192.168.0.12`.
+1. Edit `openssh/sshd_config` and
+   - set `ListenAddress` to `192.168.0.12`
+   - add `AcceptEnv GIT_PROTOCOL` to allow use of [Git protocol v2][Git protocol]
 1. Restart your GDK
 1. Run the QA scenario as follows:
 
@@ -141,6 +143,7 @@ You should be able to use your navigator and point it to `http://gitlab-primary.
 [Docker Networking]: https://docs.docker.com/docker-for-mac/networking/#known-limitations-use-cases-and-workarounds
 [Docker bridge issue]: https://github.com/moby/moby/issues/22753#issuecomment-253534261
 [dnsdock]: https://github.com/aacebedo/dnsdock
+[Git protocol]: https://docs.gitlab.com/ee/administration/git_protocol.html#doc-nav
 
 ----
 

docs/what_tests_can_be_run.md

@@ -44,6 +44,7 @@ For more details on the internals, please read the
 * `CHROME_HEADLESS` - when running locally, set to `false` to allow Chrome tests to be visible - watch your tests being run
 * `QA_DEBUG` - set to `true` to verbosely log page object actions. Note: if enabled be aware that sensitive data might be logged. If an input element has a QA selector with `password` in the name, data entered into the input element will be masked. If the element doesn't have `password` in its name it won't be masked.
 * `QA_LOG_PATH` - path to output debug logging to. If not set logging will be output to STDOUT
+* `QA_CAN_TEST_GIT_PROTOCOL_V2` - set to `false` to skip tests that require Git protocol v2 if your environment doesn't support it.
 
 ### `Test::Instance::Image CE|EE|<full image address>`
 

lib/gitlab/qa/runtime/env.rb

@@ -29,7 +29,8 @@ module Gitlab
           'GCLOUD_ZONE' => :gcloud_zone,
           'SIGNUP_DISABLED' => :signup_disabled,
           'QA_DEBUG' => :qa_debug,
-          'QA_LOG_PATH' => :qa_log_path
+          'QA_LOG_PATH' => :qa_log_path,
+          'QA_CAN_TEST_GIT_PROTOCOL_V2' => :qa_can_test_git_protocol_v2
         }.freeze
 
         ENV_VARIABLES.each_value do |accessor|