Skip to content

Fix broken multiple-domain project configurations

John Papandriopoulos requested to merge (removed):fix-multi-domain-config into master

Project sites that contain multiple configurations (domain, TLS cert/key) are broken in GitLab Pages. Only the first TLS configuration is actually enabled, because in readProjectConfig, references to only the first JSON entry are passed to addDomain.

This MR fixes the issue, and also removes the for ... range copy that was perhaps not meant to be introduced by the original author.

I hope this is merged in quickly, because GitLab.com is currently serving the wrong SSL certificates for GitLab Pages that have separate certificates for the site.com and www.site.com domains.

This was originally reported on the support forum some days ago. (Marked as a confidential issue, so may be hidden from your view.)

Merge request reports