Support HTTP and HTTPS on non-standard ports
Noticed while working on !106 (merged)
internal/domain/domain.go
has at least 3 sites that assume http.Request#Host
will not have a port included. If someone connects directly to Pages on port 8080, for instance (rather than going through a proxy and having X-Forwarded-Host
set), the port will be included in the Host:
header, and those code paths will break.
This is a fairly niche use case, but one that we should support, since it opens the possibility of running pages and gitlab on the same IP with all functionality.