refactor: make the feature package easier to mock
The following discussion from !642 should be addressed: - [ ] @vshushlin started a [discussion](https://gitlab.com/gitlab-org/gitlab-pages/-/merge_requests/642#note_774380721): (+2 comments) > This is a bit of glue between tests and `feature` package. We pass `envVar` as the string mainly to resolve the circular dependency between `feature` and `testhelpers` > > 1. tests for `feature` use `testhelpers.SetEnvironmentVariable ` > 1. I'd love this function `func StubFeatureFlagValue(t testing.TB, f feature.Feature, value bool)`, but it would be circular dependency > 1. I also considered something like `func (f Feature) Stub(t testing.TB, value bool)`, but I don't want to pull the whole testing package anywhere outside of tests > > So I just use string names. This is also why `EnvVariable` is exported by `Feature` type > > I think we can iterate on solution later.
issue