Rename LookupPath defaultDomainRedirect to primaryDomain
What does this MR do?
Rename LookupPath defaultDomainRedirect
to primaryDomain
Related:
Changelog: changed
TODO
-
Feature flag -
Added feature flag: -
This feature does not require a feature flag
-
-
I added the Changelog
trailer to the commits that need to be included in the changelog (e.g.Changelog: added
) -
I added unit tests or they are not required -
I added acceptance tests or they are not required -
I added documentation (or it's not required) -
I followed code review guidelines -
I followed Go Style guidelines
Merge request reports
Activity
changed milestone to %17.8
added Category:Pages devopsplan groupknowledge sectiondev typefeature labels
assigned to @ngala
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer @rkumar555
(UTC+1, 4.5 hours behind author)
@vshushlin
(UTC+1, 4.5 hours behind author)
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 DangerEdited by ****- Resolved by Vladimir Shushlin
@janis Can you please review this change? Thank you.
requested review from @janis
requested review from @vshushlin
started a merge train
mentioned in commit 436217dc
mentioned in issue #1131 (closed)
mentioned in issue gitlab#512382 (closed)