Redirect user based on DefaultDomainRedirect for the given Pages project
What does this MR do?
Redirect user based on DefaultDomainRedirect
for the given Pages project. This MR is dependent on gitlab!173510 (merged).
Related: #1131 (closed)
Changelog: added
TODO
-
Feature flag -
Added feature flag: -
This feature does not require a feature flag
-
-
I added the Changelog
trailer to the commits that need to be included in the changelog (e.g.Changelog: added
) -
I added unit tests or they are not required -
I added acceptance tests or they are not required -
I added documentation (or it's not required) -
I followed code review guidelines -
I followed Go Style guidelines
Merge request reports
Activity
changed milestone to %17.7
assigned to @ngala
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer @vtak
(UTC+5.5, same timezone as author)
@jaime
(UTC+11, 5.5 hours ahead of author)
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by ****added 1 commit
- c216af9f - Redirect user based on DefaultDomainRedirect for the given Pages project
added 1 commit
- acd88a27 - Redirect user based on DefaultDomainRedirect for the given Pages project
added 1 commit
- 2ae0c194 - Redirect user based on DefaultDomainRedirect for the given Pages project
added 1 commit
- c1be5958 - Redirect user based on DefaultDomainRedirect for the given Pages project
added 1 commit
- 3c7b444d - Redirect user based on DefaultDomainRedirect for the given Pages project
added 1 commit
- bdaf4d2d - Redirect user based on DefaultDomainRedirect for the given Pages project
- Resolved by Alessio Caiazza
@ifrenkel Can you please review this change? Thank you.
added workflowready for review label and removed workflowin dev label
requested review from @ifrenkel
added 1 commit
- 1dd12dc2 - Redirect user based on DefaultDomainRedirect for the given Pages project
mentioned in issue #1131 (closed)
requested review from @jaime
started a merge train
mentioned in commit 0125d230