Unable to download large files from gitlab.io
Summary
If you try to download a large file from gitlab.io the connection is closed after about 37s. This is probably a regression of the recent security fix.
Steps to reproduce
Try to download a large file over a slow connection or try to rate limit your connection (wget --limit-rate
works to reproduce this issue). This affects f.e. https://gitlab.com/paulcarroty/vscodium-deb-rpm-repo. (see paulcarroty/vscodium-deb-rpm-repo#77 (closed)) If you try to download the mentioned codium_1.66.0-1648720116_amd64.deb
(80Mb) and the download requires more than about 37s the connection is closed and the download is not finished.
TODO
-
change the default to 5 minutes !722 (merged) -
make backports to versions we backported security fix to - 1.51: !723 (merged)
- 1.54: !724 (merged)
- 1.56: !725 (merged)
-
make these parameters configurable in charts and omnibus - charts: gitlab-org/charts/gitlab!2504 (merged)
- omnibus: omnibus-gitlab!6029 (merged)
-
log them in http://gitlab.com/gitlab-org/gitlab-pages/blob/4b1afecbb6ae1886bfd3a31f256909ca2770bce4/internal/config/config.go#L331-L331 -
remove the hot fix from gitlab-com/gl-infra/k8s-workloads/gitlab-com!1697 (merged)
Edited by Kassio Borges