Follow-up from "Log time with milliseconds and add more logs to verify time spent"
The following discussions from !1043 (merged) should be addressed:
-
@vshushlin started a discussion: (+3 comments) Shall we panic in that case? It would be very weird if something of a different type is stored in that key.
info := val.(*timingInfo)
-
@vshushlin started a discussion: Non-blocking/follow-up: let's make the threshold configurable after all:
func NewMiddleware(handler http.Handler, logger LoggerFunc) http.Handler {
This way, we can pass
0
in tests and avoid usingsleep
.No need to add a config flag, you can just make the
SlowRequestThreshold
public -
@vshushlin started a discussion: Follow-up/non-blocking: Can we create a
NewNullLogger
for theloggerFunc
? Here's the nice example: https://pkg.go.dev/github.com/sirupsen/logrus#readme-testing- If tests are ever executed in parallel, they won't conflict with each other
- We won't polite the test log with unnecessary messages.