Commit 70afef5c authored by Jacob Vosmaer's avatar Jacob Vosmaer Committed by Junio C Hamano
Browse files

upload-pack: use stdio in send_ref callbacks

In both protocol v0 and v2, upload-pack writes one pktline packet per
advertised ref to stdout. That means one or two write(2) syscalls per
ref. This is problematic if these writes become network sends with
high overhead.

This commit changes both send_ref callbacks to use buffered IO using

To give an example of the impact: I set up a single-threaded loop that
calls ls-remote (with HTTP and protocol v2) on a local GitLab
instance, on a repository with 11K refs. When I switch from Git
v2.32.0 to this patch, I see a 40% reduction in CPU time for Git, and
65% for Gitaly (GitLab's Git RPC service).

So using buffered IO not only saves syscalls in upload-pack, it also
saves time in things that consume upload-pack's output.
Helped-by: default avatarJeff King <>
Signed-off-by: Jacob Vosmaer's avatarJacob Vosmaer <>
Signed-off-by: default avatarJunio C Hamano <>
parent 96328398
......@@ -105,7 +105,7 @@ static int send_ref(const char *refname, const struct object_id *oid,
strbuf_addch(&refline, '\n');
packet_write(1, refline.buf, refline.len);
packet_fwrite(stdout, refline.buf, refline.len);
return 0;
......@@ -171,7 +171,7 @@ int ls_refs(struct repository *r, struct strvec *keys,
strvec_push(&data.prefixes, "");
for_each_fullref_in_prefixes(get_git_namespace(), data.prefixes.v,
send_ref, &data, 0);
return 0;
......@@ -1207,7 +1207,7 @@ static int send_ref(const char *refname, const struct object_id *oid,
format_symref_info(&symref_info, &data->symref);
format_session_id(&session_id, data);
packet_write_fmt(1, "%s %s%c%s%s%s%s%s%s%s object-format=%s agent=%s\n",
packet_fwrite_fmt(stdout, "%s %s%c%s%s%s%s%s%s%s object-format=%s agent=%s\n",
oid_to_hex(oid), refname_nons,
0, capabilities,
(data->allow_uor & ALLOW_TIP_SHA1) ?
......@@ -1223,11 +1223,11 @@ static int send_ref(const char *refname, const struct object_id *oid,
} else {
packet_write_fmt(1, "%s %s\n", oid_to_hex(oid), refname_nons);
packet_fwrite_fmt(stdout, "%s %s\n", oid_to_hex(oid), refname_nons);
capabilities = NULL;
if (!peel_iterated_oid(oid, &peeled))
packet_write_fmt(1, "%s %s^{}\n", oid_to_hex(&peeled), refname_nons);
packet_fwrite_fmt(stdout, "%s %s^{}\n", oid_to_hex(&peeled), refname_nons);
return 0;
......@@ -1348,6 +1348,11 @@ void upload_pack(struct upload_pack_options *options)
head_ref_namespaced(send_ref, &data);
for_each_namespaced_ref(send_ref, &data);
* fflush stdout before calling advertise_shallow_grafts because send_ref
* uses stdio.
} else {
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment