Merge branch 'mr-diff-comment-button' into 'master'

Improved the diff comment button UX

Closes #27543

See merge request !9448
50 jobs for 20450-fix-ujs-actions in 75 minutes and 10 seconds (queued for 44 minutes and 56 seconds)
Status Job ID Name Coverage
  Prepare
passed #11226661
gitlab-org
knapsack

00:02:13

passed #11226663
gitlab-org
setup-test-env

00:07:42

 
  Test
passed #11226775
gitlab-org
bundler:check

00:02:21

passed #11226757
gitlab-org
license_finder

00:03:00

passed #11226773
gitlab-org
lint-doc

00:02:45

passed #11226777
gitlab-org
lint:javascript

00:04:11

passed #11226755
gitlab-org
rake brakeman

00:12:13

passed #11226754
gitlab-org
rake config_lint

00:02:39

passed #11226761
gitlab-org
rake db:migrate:reset

00:10:30

passed #11226762
gitlab-org
rake db:seed_fu

00:16:01

passed #11226759
gitlab-org
rake downtime_check

00:03:07

passed #11226760
gitlab-org allowed to fail
rake ee_compat_check

00:11:41

passed #11226756
gitlab-org
rake flay

00:02:58

passed #11226765
gitlab-org
rake gitlab:assets:compile

00:09:39

passed #11226740
gitlab-org
rake haml_lint

00:02:52

passed #11226768
gitlab-org
rake karma

00:16:38

passed #11226753
gitlab-org
rake scss_lint

00:02:52

passed #11226664
gitlab-org
rspec 0 20

00:20:03

passed #11226665
gitlab-org
rspec 1 20

00:15:34

passed #11226685
gitlab-org
rspec 10 20

00:36:59

passed #11226689
gitlab-org
rspec 11 20

00:37:57

passed #11226690
gitlab-org
rspec 12 20

00:45:42

passed #11226703
gitlab-org
rspec 13 20

00:23:18

passed #11226704
gitlab-org
rspec 14 20

00:35:45

passed #11226705
gitlab-org
rspec 15 20

00:24:44

passed #11226706
gitlab-org
rspec 16 20

00:50:11

passed #11226711
gitlab-org
rspec 17 20

00:17:56

passed #11226713
gitlab-org
rspec 18 20

00:46:20

passed #11226715
gitlab-org
rspec 19 20

00:26:38

passed #11226666
gitlab-org
rspec 2 20

00:24:51

passed #11226667
gitlab-org
rspec 3 20

00:35:19

passed #11226670
gitlab-org
rspec 4 20

00:20:18

passed #11226671
gitlab-org
rspec 5 20

01:07:02

passed #11226673
gitlab-org
rspec 6 20

00:49:38

passed #11226674
gitlab-org
rspec 7 20

00:29:57

passed #11226682
gitlab-org
rspec 8 20

00:22:43

passed #11226684
gitlab-org
rspec 9 20

00:34:22

failed #11226739
gitlab-org
rubocop

00:09:36

passed #11226723
gitlab-org
spinach 0 10

00:28:17

passed #11226724
gitlab-org
spinach 1 10

00:57:42

passed #11226726
gitlab-org
spinach 2 10

00:22:21

passed #11226729
gitlab-org
spinach 3 10

00:23:31

passed #11226731
gitlab-org
spinach 4 10

00:12:33

passed #11226732
gitlab-org
spinach 5 10

00:21:05

passed #11226733
gitlab-org
spinach 6 10

00:13:02

passed #11226735
gitlab-org
spinach 7 10

00:23:23

passed #11226736
gitlab-org
spinach 8 10

00:18:40

passed #11226738
gitlab-org
spinach 9 10

00:15:51

 
  Post Test
skipped #11226778
gitlab-org
coverage
skipped #11226779
gitlab-org
lint:javascript:report
 
Name Stage Failure
failed
rubocop Test There is an unknown failure, please try again

Offenses:

spec/support/update_invalid_issuable.rb:36:7: C: Performance/RedundantMerge: Use params[:format] = "json" instead of params.merge!(format: "json").
params.merge!(format: "json")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

3573 files inspected, 1 offense detected
ERROR: Build failed: exit code 1