Only validate project visibility when it has changed

On GitLab.com, there are hundreds of projects that have visibility
levels that are inconsistent with the fork or group settings. Most
likely, this happened during a GitLab project import because the
validation was bypassed.  Attempting to migrate these projects to hashed
storage fails even though the migration doesn't touch the visibility
settings. Skipping the visibility validation allows the migration to go
through.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55881
145 jobs for sh-skip-validation-visibility-changed in 49 minutes and 20 seconds (queued for 7 seconds)
Status Job ID Name Coverage
  Build
manual #141363535
gitlab-org allowed to fail manual
review-docs-deploy-manual
 
  Prepare
passed #141363553
gitlab-org docker
build-qa-image

00:04:24

passed #141363548
gitlab-org
compile-assets

00:07:35

passed #141363536
gitlab-org
retrieve-tests-metadata

00:00:20

passed #141363552
gitlab-org
setup-test-env

00:05:04

 
  Test
passed #141363707
allowed to fail
code_quality

00:08:30

passed #141363556
danger-review

00:01:52

passed #141363697
gitlab-org
db:check-schema-pg

00:02:11

passed #141363696
gitlab-org
db:migrate:reset-mysql

00:05:09

passed #141363695
gitlab-org
db:migrate:reset-pg

00:03:05

passed #141363701
gitlab-org
db:rollback-mysql

00:04:57

passed #141363700
gitlab-org
db:rollback-pg

00:03:04

passed #141363709
allowed to fail
dependency_scanning

00:01:21

passed #141363690
gitlab-org
docs lint

00:01:42

passed #141363693
gitlab-org
downtime_check

00:01:53

passed #141363694
gitlab-org
ee_compat_check

00:02:47

passed #141363704
gitlab-org-delivery high-cpu
gitlab:assets:compile

00:14:11

passed #141363703
gitlab-org
gitlab:setup-mysql

00:04:42

passed #141366931
gitlab-org
gitlab:setup-pg

00:05:04

passed #141363717
gitlab-org
gitlab_git_test

00:00:24

passed #141363706
gitlab-org
jest

00:09:37

passed #141363705
gitlab-org
karma

00:08:41

58.04%
passed #141363699
gitlab-org
migration:path-mysql

00:11:50

passed #141363698
gitlab-org
migration:path-pg

00:11:45

passed #141363718
gitlab-org
no_ee_check

00:00:16

manual #141363555
allowed to fail manual
package-and-qa
passed #141363715
qa-frontend-node:10

00:11:24

passed #141363712
qa-frontend-node:6

00:12:18

passed #141363714
qa-frontend-node:8

00:12:15

passed #141363716
allowed to fail
qa-frontend-node:latest

00:06:52

passed #141363710
gitlab-org
qa:internal

00:03:03

passed #141363711
gitlab-org
qa:selectors

00:02:44

passed #141363719
gitlab-org allowed to fail
review-deploy

00:29:22

manual #141363721
gitlab-org docker allowed to fail manual
review-qa-all
failed #141408035
gitlab-org docker allowed to fail
review-qa-smoke

00:06:08

passed #141363722
gitlab-org allowed to fail manual
review-stop

00:00:48

passed #141363631
gitlab-org
rspec-mysql 1/50

00:15:41

passed #141363640
gitlab-org
rspec-mysql 10/50

00:12:58

passed #141363641
gitlab-org
rspec-mysql 11/50

00:12:25

passed #141363642
gitlab-org
rspec-mysql 12/50

00:14:28

passed #141363643
gitlab-org
rspec-mysql 13/50

00:12:47

passed #141363644
gitlab-org
rspec-mysql 14/50

00:14:14

passed #141363645
gitlab-org
rspec-mysql 15/50

00:15:18

passed #141363646
gitlab-org
rspec-mysql 16/50

00:12:27

passed #141363647
gitlab-org
rspec-mysql 17/50

00:12:17

passed #141363648
gitlab-org
rspec-mysql 18/50

00:15:35

passed #141363649
gitlab-org
rspec-mysql 19/50

00:15:40

passed #141363632
gitlab-org
rspec-mysql 2/50

00:12:19

passed #141363650
gitlab-org
rspec-mysql 20/50

00:18:55

passed #141363651
gitlab-org
rspec-mysql 21/50

00:16:55

passed #141363652
gitlab-org
rspec-mysql 22/50

00:16:51

passed #141363653
gitlab-org
rspec-mysql 23/50

00:12:56

passed #141363654
gitlab-org
rspec-mysql 24/50

00:14:47

passed #141363655
gitlab-org
rspec-mysql 25/50

00:16:23

passed #141363656
gitlab-org
rspec-mysql 26/50

00:15:31

passed #141363657
gitlab-org
rspec-mysql 27/50

00:15:45

passed #141363658
gitlab-org
rspec-mysql 28/50

00:18:44

passed #141363659
gitlab-org
rspec-mysql 29/50

00:15:56

passed #141363633
gitlab-org
rspec-mysql 3/50

00:11:56

passed #141363660
gitlab-org
rspec-mysql 30/50

00:16:40

passed #141363661
gitlab-org
rspec-mysql 31/50

00:16:23

passed #141363662
gitlab-org
rspec-mysql 32/50

00:14:48

passed #141363663
gitlab-org
rspec-mysql 33/50

00:14:50

passed #141363664
gitlab-org
rspec-mysql 34/50

00:16:54

passed #141363665
gitlab-org
rspec-mysql 35/50

00:14:29

passed #141363666
gitlab-org
rspec-mysql 36/50

00:16:23

passed #141363668
gitlab-org
rspec-mysql 37/50

00:14:49

passed #141363669
gitlab-org
rspec-mysql 38/50

00:17:03

passed #141363670
gitlab-org
rspec-mysql 39/50

00:17:37

passed #141363634
gitlab-org
rspec-mysql 4/50

00:12:34

passed #141363671
gitlab-org
rspec-mysql 40/50

00:15:06

passed #141363672
gitlab-org
rspec-mysql 41/50

00:16:07

passed #141363673
gitlab-org
rspec-mysql 42/50

00:13:05

passed #141363674
gitlab-org
rspec-mysql 43/50

00:18:01

passed #141363675
gitlab-org
rspec-mysql 44/50

00:14:03

passed #141363676
gitlab-org
rspec-mysql 45/50

00:14:27

passed #141363678
gitlab-org
rspec-mysql 46/50

00:14:37

passed #141363680
gitlab-org
rspec-mysql 47/50

00:12:45

passed #141363683
gitlab-org
rspec-mysql 48/50

00:18:06

passed #141363684
gitlab-org
rspec-mysql 49/50

00:15:46

passed #141363635
gitlab-org
rspec-mysql 5/50

00:14:05

passed #141363685
gitlab-org
rspec-mysql 50/50

00:14:10

passed #141363636
gitlab-org
rspec-mysql 6/50

00:13:40

passed #141363637
gitlab-org
rspec-mysql 7/50

00:13:57

passed #141363638
gitlab-org
rspec-mysql 8/50

00:17:08

passed #141363639
gitlab-org
rspec-mysql 9/50

00:15:07

passed #141363559
gitlab-org
rspec-pg 1/50

00:12:04

passed #141363574
gitlab-org
rspec-pg 10/50

00:12:30

passed #141363575
gitlab-org
rspec-pg 11/50

00:12:20

passed #141363576
gitlab-org
rspec-pg 12/50

00:11:25

passed #141363578
gitlab-org
rspec-pg 13/50

00:11:50

passed #141363579
gitlab-org
rspec-pg 14/50

00:10:47

passed #141363580
gitlab-org
rspec-pg 15/50

00:11:59

passed #141363582
gitlab-org
rspec-pg 16/50

00:14:02

passed #141363583
gitlab-org
rspec-pg 17/50

00:11:51

passed #141363585
gitlab-org
rspec-pg 18/50

00:12:23

passed #141363586
gitlab-org
rspec-pg 19/50

00:13:55

passed #141363561
gitlab-org
rspec-pg 2/50

00:11:35

passed #141363587
gitlab-org
rspec-pg 20/50

00:11:59

passed #141363588
gitlab-org
rspec-pg 21/50

00:11:59

passed #141363589
gitlab-org
rspec-pg 22/50

00:12:35

passed #141363590
gitlab-org
rspec-pg 23/50

00:10:57

passed #141363591
gitlab-org
rspec-pg 24/50

00:12:57

passed #141363592
gitlab-org
rspec-pg 25/50

00:12:16

passed #141363593
gitlab-org
rspec-pg 26/50

00:11:53

passed #141363597
gitlab-org
rspec-pg 27/50

00:12:15

passed #141363599
gitlab-org
rspec-pg 28/50

00:12:51

passed #141363600
gitlab-org
rspec-pg 29/50

00:12:24

passed #141363562
gitlab-org
rspec-pg 3/50

00:11:03

passed #141363601
gitlab-org
rspec-pg 30/50

00:13:04

passed #141363602
gitlab-org
rspec-pg 31/50

00:13:38

passed #141363603
gitlab-org
rspec-pg 32/50

00:13:02

passed #141363604
gitlab-org
rspec-pg 33/50

00:15:16

passed #141363605
gitlab-org
rspec-pg 34/50

00:12:20

passed #141363606
gitlab-org
rspec-pg 35/50

00:12:59

passed #141363607
gitlab-org
rspec-pg 36/50

00:12:46

passed #141363609
gitlab-org
rspec-pg 37/50

00:12:46

passed #141363610
gitlab-org
rspec-pg 38/50

00:12:48

passed #141363611
gitlab-org
rspec-pg 39/50

00:16:01

passed #141363564
gitlab-org
rspec-pg 4/50

00:11:26

passed #141363612
gitlab-org
rspec-pg 40/50

00:13:30

passed #141363613
gitlab-org
rspec-pg 41/50

00:15:02

passed #141363615
gitlab-org
rspec-pg 42/50

00:15:29

passed #141363616
gitlab-org
rspec-pg 43/50

00:12:14

passed #141363618
gitlab-org
rspec-pg 44/50

00:11:31

passed #141363620
gitlab-org
rspec-pg 45/50

00:14:41

passed #141363622
gitlab-org
rspec-pg 46/50

00:14:47

passed #141363625
gitlab-org
rspec-pg 47/50

00:15:29

passed #141363627
gitlab-org
rspec-pg 48/50

00:14:29

passed #141363629
gitlab-org
rspec-pg 49/50

00:12:52

passed #141363565
gitlab-org
rspec-pg 5/50

00:12:13

passed #141363630
gitlab-org
rspec-pg 50/50

00:15:16

passed #141363570
gitlab-org
rspec-pg 6/50

00:11:32

passed #141363571
gitlab-org
rspec-pg 7/50

00:12:53

passed #141363572
gitlab-org
rspec-pg 8/50

00:14:36

passed #141363573
gitlab-org
rspec-pg 9/50

00:12:28

passed #141363708
allowed to fail
sast

00:04:01

passed #141363686
gitlab-org
static-analysis

00:11:23

failed #141363702
gitlab-org
gitlab:setup-pg

00:02:20

failed #141363720
gitlab-org docker allowed to fail
review-qa-smoke

01:21:29

failed #141391684
docker gitlab-org allowed to fail
review-qa-smoke

00:37:07

 
  Post Test
passed #141363724
gitlab-org
coverage

00:05:16

100.0%
passed #141363723
gitlab-org allowed to fail
flaky-examples-check

00:01:38

passed #141363725
gitlab-org
lint:javascript:report

00:03:22

 
  Post Cleanup
manual #141363726
gitlab-org allowed to fail manual
review-docs-cleanup
 
Name Stage Failure
failed
review-qa-smoke Test
Randomized with seed 22591

Running after script...
$ date
Fri Jan 4 09:45:35 UTC 2019
Uploading artifacts...
./qa/gitlab-qa-run-*: found 12 matching files
Uploading artifacts to coordinator... ok
id=141408035 responseStatus=201 Created token=xyPiPP4S
ERROR: Job failed: exit code 1