Merge branch 'diff-line-comment-vuejs' into 'master'
Diff line comments resolve ## What does this MR do? Diff line comments can be resolved. Part of #10325 To do: - [x] Backend (@DouweM) - [x] Fix https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5022#note_13319326. Will be made easier by https://gitlab.com/gitlab-org/gitlab-ce/issues/17237#note_13370331 - [x] System note when all discussions are resolved - [x] Notification when all discussions are resolved - [x] Write unit tests - [x] Look at resolve time https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5022#note_13912743 - Fixed by 4a13aa9f - [x] Frontend (@iamphill) - [x] Fix bugs - [x] Write more feature tests - [x] Frontend (@connorshea) - [x] Address frontend feedback - [x] Feature specs for Jump feature - [x] Documentation - [x] Add Vue.js in a standard way See merge request !5022
| Status | Job ID | Name | Coverage | ||||||
|---|---|---|---|---|---|---|---|---|---|
| Prepare | |||||||||
| passed |
#3228382
|
knapsack |
00:01:49
|
|
|||||
| Test | |||||||||
| passed |
#3228459
|
bundler:audit |
00:05:05
|
|
|||||
| passed |
#3228454
|
license_finder |
00:05:06
|
|
|||||
| passed |
#3228458
|
lint-doc |
00:06:24
|
|
|||||
| passed |
#3228451
|
rake brakeman |
00:06:45
|
|
|||||
| passed |
#3228456
|
rake db:migrate:reset |
00:05:54
|
|
|||||
| passed |
#3228455
|
rake downtime_check |
00:04:37
|
|
|||||
| passed |
#3228453
|
rake flay |
00:02:52
|
|
|||||
| passed |
#3228452
|
rake flog |
00:05:15
|
|
|||||
| passed |
#3228449
|
rake scss_lint |
00:03:16
|
|
|||||
| passed |
#3228383
|
rspec 0 20 |
00:26:22
|
|
|||||
| passed |
#3228415
|
rspec 0 20 ruby21 |
00:22:14
|
|
|||||
| passed |
#3228384
|
rspec 1 20 |
00:24:54
|
|
|||||
| passed |
#3228416
|
rspec 1 20 ruby21 |
00:28:17
|
|
|||||
| passed |
#3228394
|
rspec 10 20 |
00:26:48
|
|
|||||
| passed |
#3228426
|
rspec 10 20 ruby21 |
00:23:50
|
|
|||||
| passed |
#3228395
|
rspec 11 20 |
00:24:30
|
|
|||||
| passed |
#3228427
|
rspec 11 20 ruby21 |
00:33:14
|
|
|||||
| passed |
#3228396
|
rspec 12 20 |
00:22:43
|
|
|||||
| passed |
#3228428
|
rspec 12 20 ruby21 |
00:26:14
|
|
|||||
| passed |
#3228398
|
rspec 13 20 |
00:22:10
|
|
|||||
| passed |
#3228429
|
rspec 13 20 ruby21 |
00:23:11
|
|
|||||
| passed |
#3228399
|
rspec 14 20 |
00:24:07
|
|
|||||
| passed |
#3228430
|
rspec 14 20 ruby21 |
00:25:11
|
|
|||||
| passed |
#3228400
|
rspec 15 20 |
00:22:24
|
|
|||||
| passed |
#3228431
|
rspec 15 20 ruby21 |
00:25:06
|
|
|||||
| passed |
#3228401
|
rspec 16 20 |
00:33:26
|
|
|||||
| passed |
#3228432
|
rspec 16 20 ruby21 |
00:28:20
|
|
|||||
| passed |
#3228402
|
rspec 17 20 |
00:24:20
|
|
|||||
| passed |
#3229170
|
rspec 17 20 ruby21 |
00:23:43
|
|
|||||
| passed |
#3228403
|
rspec 18 20 |
00:21:58
|
|
|||||
| passed |
#3228434
|
rspec 18 20 ruby21 |
00:26:47
|
|
|||||
| passed |
#3228404
|
rspec 19 20 |
00:22:26
|
|
|||||
| passed |
#3228435
|
rspec 19 20 ruby21 |
00:27:43
|
|
|||||
| passed |
#3228385
|
rspec 2 20 |
00:28:43
|
|
|||||
| passed |
#3228417
|
rspec 2 20 ruby21 |
00:43:36
|
|
|||||
| passed |
#3228386
|
rspec 3 20 |
00:23:08
|
|
|||||
| passed |
#3228419
|
rspec 3 20 ruby21 |
00:24:07
|
|
|||||
| passed |
#3228387
|
rspec 4 20 |
00:24:08
|
|
|||||
| passed |
#3228420
|
rspec 4 20 ruby21 |
00:25:52
|
|
|||||
| passed |
#3228388
|
rspec 5 20 |
00:26:04
|
|
|||||
| passed |
#3228421
|
rspec 5 20 ruby21 |
00:40:57
|
|
|||||
| passed |
#3228389
|
rspec 6 20 |
00:34:53
|
|
|||||
| passed |
#3228422
|
rspec 6 20 ruby21 |
00:33:34
|
|
|||||
| passed |
#3228390
|
rspec 7 20 |
00:20:40
|
|
|||||
| passed |
#3228423
|
rspec 7 20 ruby21 |
00:27:00
|
|
|||||
| passed |
#3228391
|
rspec 8 20 |
00:24:09
|
|
|||||
| passed |
#3228424
|
rspec 8 20 ruby21 |
00:38:40
|
|
|||||
| passed |
#3228392
|
rspec 9 20 |
00:23:19
|
|
|||||
| passed |
#3228425
|
rspec 9 20 ruby21 |
00:32:43
|
|
|||||
| passed |
#3228448
|
rubocop |
00:07:25
|
|
|||||
| passed |
#3228405
|
spinach 0 10 |
00:14:11
|
|
|||||
| passed |
#3228436
|
spinach 0 10 ruby21 |
00:18:08
|
|
|||||
| passed |
#3228406
|
spinach 1 10 |
00:14:08
|
|
|||||
| passed |
#3228437
|
spinach 1 10 ruby21 |
00:16:08
|
|
|||||
| passed |
#3228407
|
spinach 2 10 |
00:16:46
|
|
|||||
| passed |
#3228438
|
spinach 2 10 ruby21 |
00:12:18
|
|
|||||
| passed |
#3228408
|
spinach 3 10 |
00:14:29
|
|
|||||
| passed |
#3228439
|
spinach 3 10 ruby21 |
00:18:13
|
|
|||||
| passed |
#3228409
|
spinach 4 10 |
00:19:53
|
|
|||||
| passed |
#3228442
|
spinach 4 10 ruby21 |
00:24:59
|
|
|||||
| passed |
#3228410
|
spinach 5 10 |
00:14:36
|
|
|||||
| passed |
#3228443
|
spinach 5 10 ruby21 |
00:22:45
|
|
|||||
| passed |
#3228411
|
spinach 6 10 |
00:14:41
|
|
|||||
| passed |
#3228444
|
spinach 6 10 ruby21 |
00:17:33
|
|
|||||
| passed |
#3228412
|
spinach 7 10 |
00:15:27
|
|
|||||
| passed |
#3228445
|
spinach 7 10 ruby21 |
00:11:45
|
|
|||||
| passed |
#3228413
|
spinach 8 10 |
00:13:58
|
|
|||||
| passed |
#3228446
|
spinach 8 10 ruby21 |
00:16:06
|
|
|||||
| passed |
#3228414
|
spinach 9 10 |
00:12:31
|
|
|||||
| passed |
#3228447
|
spinach 9 10 ruby21 |
00:22:10
|
|
|||||
| passed |
#3228457
|
teaspoon |
00:07:44
|
|
|||||
| failed |
#3228433
|
rspec 17 20 ruby21 |
00:05:47
|
|
|||||
| Post Test | |||||||||
| skipped |
#3228461
|
coverage |
|
||||||
| passed |
#3228462
|
notify:slack |
00:05:58
|
|
|||||
| skipped |
#3228460
|
update-knapsack |
|
||||||
| Pages | |||||||||
| skipped |
#3228463
|
pages |
|
||||||