Merge branch '14256-upload-destroy-removes-file' into 'master'

Uploads should delete files when destroyed

Closes #14256

See merge request gitlab-org/gitlab-ce!16799
91 jobs for master in 34 minutes and 41 seconds (queued for 31 seconds)
Status Job ID Name Coverage
  Build
manual #51318730
gitlab-org allowed to fail manual
package-qa
manual #51318731
gitlab-org allowed to fail manual
review-docs-deploy
 
  Prepare
passed #51318733
gitlab-org
compile-assets

00:08:29

passed #51318732
gitlab-org
retrieve-tests-metadata

00:00:21

passed #51318734
gitlab-org
setup-test-env

00:08:28

 
  Test
passed #51318826
gitlab-org
cache gems

00:03:28

passed #51318822
codequality

00:12:54

passed #51318813
gitlab-org
db:check-schema-pg

00:03:52

passed #51318812
gitlab-org
db:migrate:reset-mysql

00:02:57

passed #51318810
gitlab-org
db:migrate:reset-pg

00:02:21

passed #51318817
gitlab-org
db:rollback-mysql

00:03:25

passed #51318816
gitlab-org
db:rollback-pg

00:04:20

passed #51318808
gitlab-org
docs lint

00:00:49

passed #51318820
gitlab-org
gitlab:assets:compile

00:07:49

passed #51318819
gitlab-org
gitlab:setup-mysql

00:09:52

passed #51318818
gitlab-org
gitlab:setup-pg

00:09:19

passed #51318827
gitlab-org
gitlab_git_test

00:00:40

passed #51322749
gitlab-org
karma

00:06:38

53.64%
passed #51318815
gitlab-org
migration:path-mysql

00:10:16

passed #51318814
gitlab-org
migration:path-pg

00:11:02

passed #51318824
gitlab-org
qa:internal

00:09:52

passed #51318825
gitlab-org
qa:selectors

00:09:08

passed #51318767
gitlab-org
rspec-mysql 0 27

00:15:09

passed #51318773
gitlab-org
rspec-mysql 1 27

00:12:44

passed #51318783
gitlab-org
rspec-mysql 10 27

00:15:23

passed #51318784
gitlab-org
rspec-mysql 11 27

00:12:48

passed #51318785
gitlab-org
rspec-mysql 12 27

00:12:11

passed #51318786
gitlab-org
rspec-mysql 13 27

00:13:20

passed #51318787
gitlab-org
rspec-mysql 14 27

00:13:19

passed #51318788
gitlab-org
rspec-mysql 15 27

00:09:35

passed #51318789
gitlab-org
rspec-mysql 16 27

00:13:02

passed #51318790
gitlab-org
rspec-mysql 17 27

00:14:49

passed #51318791
gitlab-org
rspec-mysql 18 27

00:13:29

passed #51318792
gitlab-org
rspec-mysql 19 27

00:12:08

passed #51318775
gitlab-org
rspec-mysql 2 27

00:15:27

passed #51318793
gitlab-org
rspec-mysql 20 27

00:13:25

passed #51318794
gitlab-org
rspec-mysql 21 27

00:12:24

passed #51318795
gitlab-org
rspec-mysql 22 27

00:17:25

passed #51318796
gitlab-org
rspec-mysql 23 27

00:12:46

passed #51318797
gitlab-org
rspec-mysql 24 27

00:14:16

passed #51318798
gitlab-org
rspec-mysql 25 27

00:16:17

passed #51318799
gitlab-org
rspec-mysql 26 27

00:13:03

passed #51318776
gitlab-org
rspec-mysql 3 27

00:12:25

passed #51318777
gitlab-org
rspec-mysql 4 27

00:12:17

passed #51318778
gitlab-org
rspec-mysql 5 27

00:15:53

passed #51318779
gitlab-org
rspec-mysql 6 27

00:14:04

passed #51318780
gitlab-org
rspec-mysql 7 27

00:12:00

passed #51318781
gitlab-org
rspec-mysql 8 27

00:13:45

passed #51318782
gitlab-org
rspec-mysql 9 27

00:13:08

passed #51318735
gitlab-org
rspec-pg 0 27

00:13:19

passed #51318736
gitlab-org
rspec-pg 1 27

00:16:25

passed #51318745
gitlab-org
rspec-pg 10 27

00:16:37

passed #51318746
gitlab-org
rspec-pg 11 27

00:18:16

passed #51318747
gitlab-org
rspec-pg 12 27

00:15:16

passed #51318748
gitlab-org
rspec-pg 13 27

00:21:54

passed #51318750
gitlab-org
rspec-pg 14 27

00:19:13

passed #51318753
gitlab-org
rspec-pg 15 27

00:19:11

passed #51318754
gitlab-org
rspec-pg 16 27

00:21:12

passed #51318756
gitlab-org
rspec-pg 17 27

00:16:19

passed #51318757
gitlab-org
rspec-pg 18 27

00:18:06

passed #51318758
gitlab-org
rspec-pg 19 27

00:17:38

passed #51318737
gitlab-org
rspec-pg 2 27

00:12:14

passed #51318760
gitlab-org
rspec-pg 20 27

00:19:31

passed #51318761
gitlab-org
rspec-pg 21 27

00:20:59

passed #51318762
gitlab-org
rspec-pg 22 27

00:20:25

passed #51318763
gitlab-org
rspec-pg 23 27

00:16:24

passed #51318764
gitlab-org
rspec-pg 24 27

00:15:34

passed #51318765
gitlab-org
rspec-pg 25 27

00:18:17

passed #51318766
gitlab-org
rspec-pg 26 27

00:17:24

passed #51318738
gitlab-org
rspec-pg 3 27

00:16:24

passed #51318739
gitlab-org
rspec-pg 4 27

00:10:46

passed #51318740
gitlab-org
rspec-pg 5 27

00:11:40

passed #51318741
gitlab-org
rspec-pg 6 27

00:17:14

passed #51318742
gitlab-org
rspec-pg 7 27

00:16:43

passed #51318743
gitlab-org
rspec-pg 8 27

00:15:28

passed #51318744
gitlab-org
rspec-pg 9 27

00:14:20

passed #51318823
sast

00:07:02

passed #51318803
gitlab-org
spinach-mysql 0 3

00:10:10

passed #51318804
gitlab-org
spinach-mysql 1 3

00:11:45

passed #51318805
gitlab-org
spinach-mysql 2 3

00:09:37

passed #51318800
gitlab-org
spinach-pg 0 3

00:09:18

passed #51318801
gitlab-org
spinach-pg 1 3

00:11:16

passed #51318802
gitlab-org
spinach-pg 2 3

00:09:48

passed #51318806
gitlab-org
static-analysis

00:06:27

failed #51318821
gitlab-org
karma

00:07:35

 
  Post Test
passed #51318829
gitlab-org
coverage

00:02:22

94.65%
passed #51318830
gitlab-org
lint:javascript:report

00:01:39

passed #51318828
gitlab-org
update-tests-metadata

00:03:10

 
  Pages
passed #51318831
gitlab-org
pages

00:00:47

 
  Post Cleanup
manual #51318832
gitlab-org allowed to fail manual
review-docs-cleanup
 
  Deploy
failed pages:deploy

00:01:17