Merge branch 'issue_35873' into 'master'

Commenting on image diffs

Closes #35873 and #38559

See merge request gitlab-org/gitlab-ce!14061
86 jobs for master in 64 minutes and 11 seconds (queued for 6 seconds)
Status Job ID Name Coverage
  Build
manual #35407775
allowed to fail manual
build-package
manual #35407776
allowed to fail manual
review-docs-deploy
 
  Prepare
passed #35407777
gitlab-org
retrieve-tests-metadata

00:01:28

passed #35407778
gitlab-org
setup-test-env

00:13:45

 
  Test
passed #35407853
gitlab-org
cache gems

00:01:45

passed #35407852
codeclimate

00:07:27

passed #35407849
gitlab-org
db:check-schema-pg

00:01:29

passed #35407842
gitlab-org
db:migrate:reset-mysql

00:05:19

passed #35407841
gitlab-org
db:migrate:reset-pg

00:02:23

passed #35407846
gitlab-org
db:rollback-mysql

00:04:00

passed #35407845
gitlab-org
db:rollback-pg

00:02:09

passed #35407848
gitlab-org
db:seed_fu-mysql

00:01:49

passed #35407847
gitlab-org
db:seed_fu-pg

00:04:38

passed #35407840
gitlab-org
docs lint

00:00:44

passed #35407850
gitlab-org
gitlab:assets:compile

00:10:17

passed #35407854
gitlab_git_test

00:01:53

passed #35407851
gitlab-org
karma

00:13:00

51.73%
passed #35407844
gitlab-org
migration:path-mysql

00:25:44

passed #35407843
gitlab-org
migration:path-pg

00:14:41

passed #35407804
gitlab-org
rspec-mysql 0 25

00:14:00

passed #35407805
gitlab-org
rspec-mysql 1 25

00:14:45

passed #35407814
gitlab-org
rspec-mysql 10 25

00:14:57

passed #35407815
gitlab-org
rspec-mysql 11 25

00:15:53

passed #35407816
gitlab-org
rspec-mysql 12 25

00:15:12

passed #35407817
gitlab-org
rspec-mysql 13 25

00:12:32

passed #35407818
gitlab-org
rspec-mysql 14 25

00:12:37

passed #35407819
gitlab-org
rspec-mysql 15 25

00:20:48

passed #35407820
gitlab-org
rspec-mysql 16 25

00:13:30

passed #35407821
gitlab-org
rspec-mysql 17 25

00:12:34

passed #35407822
gitlab-org
rspec-mysql 18 25

00:13:33

passed #35407823
gitlab-org
rspec-mysql 19 25

00:15:21

passed #35407806
gitlab-org
rspec-mysql 2 25

00:12:59

passed #35407824
gitlab-org
rspec-mysql 20 25

00:14:34

passed #35407825
gitlab-org
rspec-mysql 21 25

00:15:11

passed #35407826
gitlab-org
rspec-mysql 22 25

00:15:08

passed #35407827
gitlab-org
rspec-mysql 23 25

00:13:45

passed #35407828
gitlab-org
rspec-mysql 24 25

00:15:02

passed #35407807
gitlab-org
rspec-mysql 3 25

00:15:46

passed #35407808
gitlab-org
rspec-mysql 4 25

00:13:54

passed #35407809
gitlab-org
rspec-mysql 5 25

00:18:20

passed #35407810
gitlab-org
rspec-mysql 6 25

00:12:08

passed #35407811
gitlab-org
rspec-mysql 7 25

00:14:59

passed #35407812
gitlab-org
rspec-mysql 8 25

00:14:30

passed #35407813
gitlab-org
rspec-mysql 9 25

00:18:31

passed #35407779
gitlab-org
rspec-pg 0 25

00:20:41

passed #35407780
gitlab-org
rspec-pg 1 25

00:32:23

passed #35407789
gitlab-org
rspec-pg 10 25

00:17:29

passed #35407790
gitlab-org
rspec-pg 11 25

00:22:25

passed #35407791
gitlab-org
rspec-pg 12 25

00:19:01

passed #35407792
gitlab-org
rspec-pg 13 25

00:18:54

passed #35407793
gitlab-org
rspec-pg 14 25

00:16:15

passed #35407794
gitlab-org
rspec-pg 15 25

00:19:38

passed #35407795
gitlab-org
rspec-pg 16 25

00:47:20

passed #35407796
gitlab-org
rspec-pg 17 25

00:34:06

passed #35407797
gitlab-org
rspec-pg 18 25

00:15:27

passed #35407798
gitlab-org
rspec-pg 19 25

00:17:53

passed #35407781
gitlab-org
rspec-pg 2 25

00:37:35

passed #35407799
gitlab-org
rspec-pg 20 25

00:26:28

passed #35407800
gitlab-org
rspec-pg 21 25

00:24:59

passed #35407801
gitlab-org
rspec-pg 22 25

00:30:11

passed #35407802
gitlab-org
rspec-pg 23 25

00:21:02

passed #35407803
gitlab-org
rspec-pg 24 25

00:23:16

passed #35407782
gitlab-org
rspec-pg 3 25

00:35:04

passed #35407783
gitlab-org
rspec-pg 4 25

00:28:24

passed #35407784
gitlab-org
rspec-pg 5 25

00:26:32

passed #35407785
gitlab-org
rspec-pg 6 25

00:17:03

passed #35407786
gitlab-org
rspec-pg 7 25

00:37:13

passed #35407787
gitlab-org
rspec-pg 8 25

00:15:16

passed #35407788
gitlab-org
rspec-pg 9 25

00:21:48

passed #35407834
gitlab-org
spinach-mysql 0 5

00:13:47

passed #35407835
gitlab-org
spinach-mysql 1 5

00:08:30

passed #35407836
gitlab-org
spinach-mysql 2 5

00:08:19

passed #35407837
gitlab-org
spinach-mysql 3 5

00:10:05

passed #35407838
gitlab-org
spinach-mysql 4 5

00:25:48

passed #35407829
gitlab-org
spinach-pg 0 5

00:09:39

passed #35407830
gitlab-org
spinach-pg 1 5

00:10:24

passed #35407831
gitlab-org
spinach-pg 2 5

00:07:08

passed #35407832
gitlab-org
spinach-pg 3 5

00:14:21

passed #35407833
gitlab-org
spinach-pg 4 5

00:08:23

passed #35407839
gitlab-org
static-analysis

00:24:12

 
  Post Test
passed #35407857
gitlab-org
coverage

00:02:04

93.73%
passed #35407858
gitlab-org
lint:javascript:report

00:02:19

passed #35407855
gitlab-org
update-tests-metadata

00:01:32

 
  Pages
passed #35407859
gitlab-org
pages

00:00:41

 
  Post Cleanup
manual #35407860
allowed to fail manual
review-docs-cleanup
 
  Deploy
passed pages:deploy

00:00:29