Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS
GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • Container Registry
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge Requests
  • !8266

You need to sign in or sign up before continuing.
Merged
Opened Dec 22, 2016 by Bob Van Landuyt@reprazent14 of 15 tasks completed14/15 tasks
  • Report abuse
Report abuse

Create a new issue for a single discussion

What does this MR do?

Based on what is shown in #25515 (moved) I want to make it possible to create a new Issue for a single discussion in a merge request.

It also adds a button to resolve all discussions mentioned in https://gitlab.com/gitlab-org/gitlab-ce/issues/23589#note_18864573

  • Add a button to resolve a single discussion to the merge request view
  • Pre-fill a new issue when passing a a discussion to resolve
  • Resolve the discussion when creating the issue
  • Add a system note to the discussion mentioning the new issue
  • Hide the button after the issue was resolved
  • Add button to resolve all discussions in an MR

Why was this MR needed?

This is the backend part that is required to complete #25515 (moved).

Screenshots (if relevant)

The warning on the new-issue form looks like this for all discussions in an MR:

Screen_Shot_2017-02-27_at_17.29.04

And like this for a single discussion:

Screen_Shot_2017-02-27_at_17.31.34

There's a new button to create a new issue for a single discussion:

Screen_Shot_2017-01-23_at_22.45.05

And there is a button to delegate all discussions in a merge request

Screen_Shot_2017-03-08_at_20.50.58

After the issue is created, this is mentioned in a flash message:

Screen_Shot_2017-03-08_at_20.18.21

Does this MR meet the acceptance criteria?

  • Changelog entry added
  • Documentation created/updated
  • API support added
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Branch has no merge conflicts with master (if it does - rebase it please)
  • Squashed related commits together

What are the relevant issue numbers?

#25515 (moved)

  • Discussion 143
  • Changes 41
Assignee
Assign to
9.1
Milestone
9.1
Assign milestone
Time tracking
4
Labels
Community contribution Plan [DEPRECATED] devops::plan issues
Assign labels
  • View project labels
Reference: gitlab-org/gitlab-foss!8266

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.