Skip to content

Minor improvements to nested groups code

Dmytro Zaporozhets (DZ) requested to merge dz-nested-group-improvements-2 into master

What does this MR do?

  1. Added nested group factory for tests
  2. Validate presence of route by Routable concern
  3. Rename Routable.where_paths_in to Routable.where_full_path_in based on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7121?view=inline#note_19746337

Are there points in the code the reviewer needs to double check?

no

Why was this MR needed?

  • Ensure namespace/project has a route.
  • Nested group factory will be needed for future tests

Screenshots (if relevant)

no

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/2772

Merge request reports