Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS
GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • Container Registry
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge Requests
  • !7125

Merged
Opened Oct 26, 2016 by Rémy Coutable@rymai🔴8 of 9 tasks completed8/9 tasks
  • Report abuse
Report abuse

Add setting to only allow merge requests to be merged when all discussions are resolved

Originally opened at !6385 (closed) by @rodolfoasantos.


What does this MR do?

Based on #20968 (closed) this merge request adds setting only to allow merge requests to be merged when all discussions are resolved.

Are there points in the code the reviewer needs to double check?

Check if there are other points to add the resolved discussion setting

Why was this MR needed?

Add the possibility to configure the project to only accept merge request when all discussions are resolved

Screenshots

only_allow_merge_if_all_discussions_are_resolved

only_allow_merge_if_all_discussions_are_resolved_msg

Does this MR meet the acceptance criteria?

  • CHANGELOG entry added
  • Documentation created/updated
  • API support added
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Branch has no merge conflicts with master (if you do - rebase it please)
  • Squashed related commits together

What are the relevant issue numbers?

Closes #20968 (closed)

  • Discussion 13
  • Commits 3
  • Pipelines 7
  • Changes 20
Assignee
Assign to
8.14
Milestone
8.14
Assign milestone
Time tracking
4
Labels
Community contribution Plan [DEPRECATED] devops::plan merge requests
Assign labels
  • View project labels
Reference: gitlab-org/gitlab-foss!7125

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.