Skip to content

Make Omniauth providers specs to not modify global configuration

Kamil Trzciński requested to merge make-omniauth-tests-to-not-modify-global-state into master

What does this MR do?

Fixes CI failures like this:

 NoMethodError:
       undefined method `[]' for nil:NilClass
     # ./lib/gitlab/github_import/client.rb:56:in `github_options'
     # ./lib/gitlab/github_import/client.rb:10:in `initialize'
     # ./lib/gitlab/github_import/importer.rb:17:in `new'
     # ./lib/gitlab/github_import/importer.rb:17:in `initialize'
     # ./app/services/projects/import_service.rb:62:in `new'
     # ./app/services/projects/import_service.rb:62:in `importer'
     # ./app/services/projects/import_service.rb:51:in `import_data'
     # ./app/services/projects/import_service.rb:23:in `execute'
     # ./spec/services/projects/import_service_spec.rb:106:in `block (4 levels) in <top (required)>'

Why was this MR needed?

The specs should not modify global objects. It should use method shadowing instead.

Merge request reports