Skip to content

Avoid Devise "401 Unauthorized" responses

Nick Thomas requested to merge (removed):62614-fix-devise-401-responses into master

What does this MR do?

Avoid Devise "401 Unauthorized" responses

Instead, in GitLab, we want to redirect to the sign-in page. This happens for most requests, but when Devise can't work out the request format, or for certain other kinds of request, it will send a very poor 401 Unauthorized instead.

This is acceptable in certain cases (XHR or git clone requests, say), but should not happen for user-visible requests - they should be redirected to sign in, instead.

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #62614 (moved)

Edited by Nick Thomas

Merge request reports