An error occurred while fetching pending comments
Avoid checking dns rebind protection in validation
What does this MR do?
This MR sets by default the dns_rebind_protection
to false
in the AddressableUrlValidator
. This way, we will only check the protection when we actually perform the request.
The reasoning behind this is that we might have to create or update records with URLs that, at the time of that operation, the URLs are not resolvable yet.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66723
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios. -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Separation of EE specific content
Edited by Francisco Javier López
Merge request reports
Activity
Please register or sign in to reply