Skip to content
Snippets Groups Projects

Avoid checking dns rebind protection in validation

Merged Francisco Javier López requested to merge fj-remove-dns-protection-when-validating into master

What does this MR do?

This MR sets by default the dns_rebind_protection to false in the AddressableUrlValidator. This way, we will only check the protection when we actually perform the request.

The reasoning behind this is that we might have to create or update records with URLs that, at the time of that operation, the URLs are not resolvable yet.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66723

Does this MR meet the acceptance criteria?

Conformity

Edited by Francisco Javier López

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading