Allow specifying variables when running manual jobs (!30485) · Merge Requests · GitLab.org / GitLab FOSS

Allow specifying variables when running manual jobs

What does this MR do?

EE MR https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14784

Backend
- Write Job variable application code
- Write Job variables database migration
- Write Job variable specs
Frontend
- Create component with form
- Render the manual variables component when playable only
- Handle secret value change
- POST request
- Update the text
- Add specs

Does this MR meet the acceptance criteria?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/24935

Conformity

Performance and testing

Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

N/A Label as security and @ mention @gitlab-com/gl-security/appsec
N/A The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
N/A Security reports checked/validated by a reviewer from the AppSec team

## What does this MR do?

EE MR https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14784

- Backend
    - [x] Write Job variable application code
    - [x] Write Job variables database migration
    - [x] Write Job variable specs
- Frontend
    - [x] Create component with form 
    - [x] Render the manual variables component when `playable` only
    - [x] Handle secret value change
    - [x] POST request
    - [x] Update the text
    - [x] Add specs

|  |  |
| ------ | ------ |
| ![Screenshot_2019-07-17_at_10.29.42](/uploads/b58fef9ece679ffe2cffdc4112daf56d/Screenshot_2019-07-17_at_10.29.42.png) | ![Screenshot_2019-07-17_at_10.30.05](/uploads/205b55d89351c881204d7cb1641e2651/Screenshot_2019-07-17_at_10.30.05.png) |
| ![Screenshot_2019-07-17_at_10.30.41](/uploads/abce101664a7361cd94d9660afd00987/Screenshot_2019-07-17_at_10.30.41.png) |![Screenshot_2019-07-17_at_10.31.33](/uploads/777146a49bd9af96cb22e25d4c471815/Screenshot_2019-07-17_at_10.31.33.png) |

## Does this MR meet the acceptance criteria?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/24935

### Conformity

- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) 
- [x] [Documentation created/updated](https://docs.gitlab.com/ee/development/documentation/feature-change-workflow.html) or [follow-up review issue created](https://gitlab.com/gitlab-org/gitlab-ce/issues/new?issuable_template=Doc%20Review)
- [x] [Code review guidelines](https://docs.gitlab.com/ee/development/code_review.html)
- [x] [Merge request performance guidelines](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] [Style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/doc/development/contributing/style_guides.md)
- [x] [Database guides](https://docs.gitlab.com/ee/development/README.html#databases-guides)
- [x] [Separation of EE specific content](https://docs.gitlab.com/ee/development/ee_features.html#separation-of-ee-code)

### Performance and testing

<!-- What risks does this change pose? How might it affect the quality/performance of the product?
What additional test coverage or changes to tests will be needed?
Will it require cross-browser testing?
See the test engineering process for further guidelines: https://about.gitlab.com/handbook/engineering/quality/guidelines/test-engineering/

If cross-browser testing is not required, please remove the relevant item, or mark it as not needed: [-] -->

- [ ] [Review and add/update tests for this feature/bug](https://docs.gitlab.com/ee/development/testing_guide/index.html). Consider [all test levels](https://docs.gitlab.com/ee/development/testing_guide/testing_levels.html). See the [Test Planning Process](https://about.gitlab.com/handbook/engineering/quality/guidelines/test-engineering/).
- [ ] [Tested in all supported browsers](https://docs.gitlab.com/ee/install/requirements.html#supported-web-browsers)

### Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in [the security review guidelines](https://about.gitlab.com/handbook/engineering/security/#when-to-request-a-security-review):

- N/A Label as ~security and @ mention `@gitlab-com/gl-security/appsec`
- N/A The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- N/A Security reports checked/validated by a reviewer from the AppSec team

Edited Jul 22, 2019 by Matija Čupić