Cache branch and tag names as Redis sets
What does this MR do?
The branch_names and tag_names methods of ::Repository are cached in Redis. These are large arrays (100KiB, json-encoded, for gitlab-ce) that we frequently use to check for the existence of a single member, particularly from the merge request widget when looking at source_branch_exists? and target_branch_exists?.
Converting these methods to be cached as redis sets allows the existence checks to be made using the SISMEMBER command. For queries that don't need the full list of branches - like the aforementioned merge request widget - this is significantly more efficient.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team