Custom username for deploy tokens (!29639) · Merge Requests · GitLab.org / GitLab FOSS

Custom username for deploy tokens

What does this MR do?

Allow users to specify a custom username for deploy tokens that will be used instead of the default one (gitlab+deploy-token-#{id}). Use the specified username in Gitlab::Auth#deploy_token_check.

Empty usernames ("") will be saved as null in the database.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
Tested in all supported browsers

Related to #50228 (closed)

## What does this MR do?

Allow users to specify a custom username for deploy tokens that will be used instead of the default one (`gitlab+deploy-token-#{id}`). Use the specified username in `Gitlab::Auth#deploy_token_check`.

Empty usernames (`""`) will be saved as null in the database.

![image](/uploads/3c4097df3d845bc8bdd81019a249e4d9/image.png)

## Does this MR meet the acceptance criteria?

### Conformity

- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) 
- [x] [Documentation created/updated](https://docs.gitlab.com/ee/development/documentation/feature-change-workflow.html) or [follow-up review issue created](https://gitlab.com/gitlab-org/gitlab-ce/issues/new?issuable_template=Doc%20Review)
- [x] [Code review guidelines](https://docs.gitlab.com/ee/development/code_review.html)
- [x] [Merge request performance guidelines](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] [Style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/doc/development/contributing/style_guides.md)
- [x] [Database guides](https://docs.gitlab.com/ee/development/README.html#databases-guides)
- [-] [Separation of EE specific content](https://docs.gitlab.com/ee/development/ee_features.html#separation-of-ee-code)

### Performance and testing

<!-- What risks does this change pose? How might it affect the quality/performance of the product?
What additional test coverage or changes to tests will be needed?
Will it require cross-browser testing?
See the test engineering process for further guidelines: https://about.gitlab.com/handbook/engineering/quality/guidelines/test-engineering/

If cross-browser testing is not required, please remove the relevant item, or mark it as not needed: [-] -->

- [x] [Review and add/update tests for this feature/bug](https://docs.gitlab.com/ee/development/testing_guide/index.html). Consider [all test levels](https://docs.gitlab.com/ee/development/testing_guide/testing_levels.html). See the [Test Planning Process](https://about.gitlab.com/handbook/engineering/quality/guidelines/test-engineering/).
- [x] [Tested in all supported browsers](https://docs.gitlab.com/ee/install/requirements.html#supported-web-browsers)

Related to #50228

Edited Jul 02, 2019 by Mayra Cabrera

Custom username for deploy tokens

What does this MR do?

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Revert this merge request

Cherry-pick this merge request