Skip to content

Bring propagated SAST ENV vars into parity with docs

Avielle Wolfe requested to merge add-missing-env-vars-to-sast-docker into master

Issue: https://gitlab.com/gitlab-org/gitlab-ee/issues/10842

What does this MR do?

I used the ENV vars from the README as a template for which ones should and should not be propagated: https://gitlab.com/gitlab-org/security-products/sast#settings

  • Adds ENV vars for analyzers that can be customized: ANT_HOME, ANT_PATH, GRADLE_PATH, JAVA_OPTS, JAVA_PATH, MAVEN_CLI_OPTS, MAVEN_PATH, MAVEN_REPO_PATH, SBT_PATH

  • Adds missing SAST ENV vars: SAST_PULL_ANALYZER_IMAGES

A separate MR updates the docs to remove a deprecated ENV var and add missing documentation for a Bandit analyzer ENV var: gitlab-org/security-products/sast!144 (merged)

This was originally an MR on EE: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14070

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Avielle Wolfe

Merge request reports