Resolve "lib/tasks/lint.rake can block indefinitely if stderr fills up"
What does this MR do?
Avoid intermediate pipes for stdout and stderr so they'll not overflow.
- Before: https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/214549815
- After: https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/214807531
Closes #61432 (closed)
Merge request reports
Activity
changed milestone to %12.0
added Quality ci-build static code analysis test labels
- Resolved by Lin Jen-Shin
Please add one of the following throughput labels: ~"bug", ~"feature", security, Community contribution, ~"backstage"
added backstage [DEPRECATED] label
added 4 commits
-
74fa088b...f2cb5220 - 2 commits from branch
master
- c7c43afb - Avoid pipes so it doesn't overflow
- 9270d05c - WIP
-
74fa088b...f2cb5220 - 2 commits from branch
assigned to @godfat
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Victor Zagorodny ( @vzagorodny
)Mayra Cabrera ( @mayra-cabrera
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 2 commits
added 74 commits
-
d29ccde3...0e36d88c - 73 commits from branch
master
- f3c5a6d8 - Avoid pipes so it doesn't overflow
-
d29ccde3...0e36d88c - 73 commits from branch
added 2 commits
@stanhu Please review, thanks!
- Resolved by Stan Hu
assigned to @godfat
unassigned @stanhu
mentioned in commit a1457259
mentioned in issue gitlab#34951 (closed)