Skip to content

WIP: feat(discussion): Added new toggle all discussions button

What does this MR do?

Added new toggle discussions button that toggles all discussions toggle-discussions

TODO:

  • Design needs approved
  • Needs new icon
  • Needs tests written and updated

Notes

The previous design suggested in #19149 (moved) is 2 years old and has been changed since so I have implemented UX that I think makes sense, feel free to come with suggestions if you think another placement of the button makes sense.

Additionally the button needs another/better icon that is relevant to the functionality it provides, not sure if you have something in the kit already?

Currently the expandAll state is handled locally in the discussionCounter component, would it make sense to move this state to the vuex store, and if so where would you locate this?

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Should have close to none performance impacts, quality should be improved as it provides a better experience for users going through long merge requests with many discussions wanting to get to the bottom.

Edited by Martin Hobert

Merge request reports