Skip to content

Resolve "Add time preferences to user [BE]"

What does this MR do?

Add a persisting layer to user time settings.

https://gitlab.com/gitlab-org/gitlab-ce/issues/57620

Database checklist

When adding migrations:

  • Updated db/schema.rb
  • Added a down method so the migration can be reverted
  • Added the output of the migration(s) to the MR body
  • Added tests for the migration in spec/migrations if necessary (e.g. when migrating data)

When adding or modifying queries to improve performance:

  • Included data that shows the performance improvement, preferably in the form of a benchmark
  • Included the output of EXPLAIN (ANALYZE, BUFFERS) of the relevant queries

When adding foreign keys to existing tables:

  • Included a migration to remove orphaned rows in the source table before adding the foreign key
  • Removed any instances of dependent: ... that may no longer be necessary

When adding tables:

  • Ordered columns based on the Ordering Table Columns guidelines
  • Added foreign keys to any columns pointing to data in other tables
  • Added indexes for fields that are used in statements such as WHERE, ORDER BY, GROUP BY, and JOINs

When removing columns, tables, indexes or other structures:

  • Removed these in a post-deployment migration
  • Made sure the application no longer uses (or ignores) these structures

General checklist

/label database

Migration output

== 20190325105715 AddFieldsToUserPreferences: migrating =======================
-- add_column(:user_preferences, :timezone, :string)
   -> 0.0011s
-- add_column(:user_preferences, :time_display_relative, :boolean)
   -> 0.0012s
-- add_column(:user_preferences, :time_format_in_24h, :boolean)
   -> 0.0008s
== 20190325105715 AddFieldsToUserPreferences: migrated (0.0033s) ==============
Edited by Gosia Ksionek

Merge request reports