Reviewer roulette via Danger
What does this MR do?
(Tries to) add reviewer roulette via Danger. The idea is that danger can scan the MR and determine what reviews it needs. Once decided, it can randomly pick a reviewer and maintainer for each category, perhaps taking OOO status into account along with any other information. It could even take CODEOWNERS information into account.
The final choice of which reviewers to use should remain with the author of the merge request - these are just suggestions to ease selection when the author doesn't have a strong opinion.
I'm new to danger
What are the relevant issue numbers?
Closes #56087 (closed)
Does this MR meet the acceptance criteria?
- [-] Changelog entry added, if necessary
-
Documentation created/updated via this MR -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the style guides -
Security reports checked/validated by reviewer
Merge request reports
Activity
added Create [DEPRECATED] Quality backstage [DEPRECATED] meta labels
added 257 commits
-
7cb41bff...3c64ad4c - 254 commits from branch
master
- 8dc84c3c - Move change category detection to a helper
- 2ebfddfa - Move the ee? helper method into the helper
- 0a0a787a - Reviewer roulette via Danger
Toggle commit list-
7cb41bff...3c64ad4c - 254 commits from branch
changed milestone to %11.9
- Resolved by Nick Thomas
- Resolved by Nick Thomas
- Resolved by Nick Thomas
- Resolved by Nick Thomas
- Resolved by Nick Thomas
- Resolved by Nick Thomas
Need to add some docs
- Resolved by Nick Thomas
1 Warning ⚠ This merge request is quite big (more than 607 lines changed), please consider splitting it into multiple merge requests. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Zeger-Jan van de Weg ( @zj
)Lin Jen-Shin ( @godfat
)~Documentation Marcia Ramos ( @marcia
)Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖^ It worked! ^
@rpereira2 do you mind giving this an initial review?
- Resolved by Nick Thomas
- Resolved by Nick Thomas
assigned to @rpereira2
This is awesome, thanks @nick.thomas! It will be hugely helpful for us new labbers who dont know good reviewer fits
- Resolved by Nick Thomas
- Resolved by Nick Thomas
Thanks @nick.thomas! Just 2 questions since I'm not familiar with Danger code.
assigned to @nick.thomas
- Resolved by Nick Thomas
- Resolved by Nick Thomas
- Resolved by Nick Thomas
- Resolved by Nick Thomas
- Resolved by Nick Thomas
assigned to @leipert
@leipert you seem to have some familiarity with danger. Could you cast an eye over this, particularly w/rt a few comments I've made (how to write specs, etc)?
- Resolved by Nick Thomas
- Resolved by Nick Thomas
- Resolved by Nick Thomas
Asked about ^ on Slack
➡ https://gitlab.slack.com/archives/C0SNC8F2N/p1549877237001400- Resolved by Nick Thomas
added 159 commits
-
efe769e7...a1215556 - 156 commits from branch
master
- 8afe42c0 - Move change category detection to a helper
- b4090a02 - Move the ee? helper method into the helper
- 4e56e39d - Reviewer roulette via Danger
Toggle commit list-
efe769e7...a1215556 - 156 commits from branch
added 1 commit
- 5e3deae3 - WIP: try to move danger helper code elsewhere
assigned to @nick.thomas