Skip to content
Snippets Groups Projects

Reviewer roulette via Danger

Merged Nick Thomas requested to merge 56087-danger-roulette into master

What does this MR do?

(Tries to) add reviewer roulette via Danger. The idea is that danger can scan the MR and determine what reviews it needs. Once decided, it can randomly pick a reviewer and maintainer for each category, perhaps taking OOO status into account along with any other information. It could even take CODEOWNERS information into account.

The final choice of which reviewers to use should remain with the author of the merge request - these are just suggestions to ease selection when the author doesn't have a strong opinion.

I'm new to danger - let's see what I can do!

What are the relevant issue numbers?

Closes #56087 (closed)

Does this MR meet the acceptance criteria?

Edited by Nick Thomas

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nick Thomas added 1 commit

    added 1 commit

    • 39b4aa58 - Reviewer roulette via Danger

    Compare with previous version

  • Nick Thomas added 1 commit

    added 1 commit

    • 8f50f15e - Reviewer roulette via Danger

    Compare with previous version

  • Nick Thomas added 1 commit

    added 1 commit

    • 89e79313 - Reviewer roulette via Danger

    Compare with previous version

  • Nick Thomas added 1 commit

    added 1 commit

    • c8e43d1c - Reviewer roulette via Danger

    Compare with previous version

  • Nick Thomas added 1 commit

    added 1 commit

    • 44a43902 - Reviewer roulette via Danger

    Compare with previous version

  • Nick Thomas added 1 commit

    added 1 commit

    • 09f3f775 - Reviewer roulette via Danger

    Compare with previous version

  • Nick Thomas added 1 commit

    added 1 commit

    • 8050b019 - Reviewer roulette via Danger

    Compare with previous version

  • 1 Warning
    This merge request is quite big (more than 607 lines changed), please consider splitting it into multiple merge requests.

    Reviewer roulette

    Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

    To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

    Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

    Category Reviewer Maintainer
    backend Zeger-Jan van de Weg (@zj) Lin Jen-Shin (@godfat)
    ~Documentation Marcia Ramos (@marcia)

    Generated by 🚫 Danger

    Edited by 🤖 GitLab Bot 🤖
  • Author Contributor

    ^ It worked! ^

    @rpereira2 do you mind giving this an initial review?

  • assigned to @rpereira2

  • This is awesome, thanks @nick.thomas! It will be hugely helpful for us new labbers who dont know good reviewer fits

  • Nick Thomas added 1 commit

    added 1 commit

    • 627e93ca - Reviewer roulette via Danger

    Compare with previous version

  • Reuben Pereira
  • Thanks @nick.thomas! Just 2 questions since I'm not familiar with Danger code.

  • Nick Thomas added 1 commit

    added 1 commit

    • 0cd4f7a1 - Reviewer roulette via Danger

    Compare with previous version

  • Nick Thomas
  • Nick Thomas
  • Nick Thomas
  • Nick Thomas added 1 commit

    added 1 commit

    • d2f54e3e - Reviewer roulette via Danger

    Compare with previous version

  • Nick Thomas
  • Nick Thomas added 1 commit

    added 1 commit

    • da854087 - Reviewer roulette via Danger

    Compare with previous version

  • Nick Thomas added 1 commit

    added 1 commit

    • ab53c0c0 - Reviewer roulette via Danger

    Compare with previous version

  • assigned to @leipert

  • Nick Thomas added 1 commit

    added 1 commit

    • efe769e7 - Reviewer roulette via Danger

    Compare with previous version

  • Author Contributor

    @leipert you seem to have some familiarity with danger. Could you cast an eye over this, particularly w/rt a few comments I've made (how to write specs, etc)?

  • Nick Thomas
  • Lukas Eipert
  • Lukas Eipert
  • Is it possible to consume data we submit to PTO Ninja to exclude maintainers that are OOO? 🤔

  • Rémy Coutable
  • Nick Thomas added 159 commits

    added 159 commits

    Compare with previous version

  • Nick Thomas added 1 commit

    added 1 commit

    • 5e3deae3 - WIP: try to move danger helper code elsewhere

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading