Fix deadlock on ChunkedIO (!23329) · Merge requests · GitLab.org / GitLab FOSS · GitLab

The 17.0 major release is coming on May 16, 2024! This version brings many exciting improvements to GitLab, but also removes some deprecated features. We are introducing three breaking change windows during which we expect breaking changes to be deployed to GitLab.com. You can read more about it on our blogpost . The first breaking change window begins 2024-04-22 09:00UTC and ends 2024-04-24 22:00UTC.

Kamil Trzciński requested to merge fix-deadlock-chunked-io into master Nov 23, 2018

What does this MR do?

This fixes a deadlock on readline where we would loop forever when the trace chunk is degenerated.

This makes this error to be voiced hard via an exception. It does not solve the problem of data corruption, but it will contain the problem.

What are the relevant issue numbers?

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/51502

Does this MR meet the acceptance criteria?

Changelog entry added, if necessary
Documentation created/updated
Tests added for this feature/bug
Conforms to the code review guidelines
Conforms to the merge request performance guidelines
Conforms to the style guides

Edited Nov 26, 2018 by Stan Hu