Skip to content

Prioritize group settings, improve panel titles, disable submit without changes

Luke Bennett requested to merge 49417-improve-settings-pages-design-by-prioritizing-content-group-settings into master

What does this MR do?

EE port: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/7720

Updates group edit (settings) page to new design from #49417 (closed)

Prioritize content within the group settings expandable panels, which includes moving visibility settings to the general panel. Make the panel titles more descriptive and only enable saving when there are changes. Update the group settings form elements to use the latest form styles.

This includes:

  • replace the 'help icons' next to input labels with proper links to documentation

  • make the section titles more descriptive (for example, users search for 'two-factor authentication' not for 'permissions')

  • the Save button should say 'Save changes'

  • the Save button should be disabled by default and become enabled when users make changes (in this case, it makes more sense like this)

  • redesign all the form elements to comply with our form guidelines

  • move 'Visibility' to the top section

  • Clicking on a section title should expand/collapse it

  • Expand first section by default

Screen_Shot_2018-08-10_at_13.54.39

Screen_Shot_2018-08-10_at_13.54.30

Screen_Shot_2018-08-10_at_13.54.19

Screen_Shot_2018-08-10_at_13.54.24

2018-08-10_13.56.03

2018-08-10_13.55.47

What are the relevant issue numbers?

Closes #49417 (closed)

Does this MR meet the acceptance criteria?

Edited by Luke Bennett

Merge request reports