Skip to content

Fixed pagination of web hook logs

Yorick Peterse requested to merge web-hooks-log-pagination into master

What does this MR do?

This fixes Projects::HooksController#edit so web hook logs are paginated using LIMIT/OFFSET, instead of doing this in memory. We also limit the logs to the last two days, just like the documentation says. See the commit message for more details.

Why was this MR needed?

Projects::HooksController#edit times out for any web hook with a reasonable amount of web hook logs (e.g. all CE web hook "Edit" pages time out). An example of this can be found in Sentry: https://sentry.gitlap.com/gitlab/gitlabcom/issues/227944/

Does this MR meet the acceptance criteria?

Edited by 🤖 GitLab Bot 🤖

Merge request reports