Skip to content

Fix could not mention members when editing merge request

What does this MR do?

Fix could not mention members when editing merge request.

There is not problem when new a merge request or issue.

Issuable form using a var called gl.GfmAutoComplete.dataSources to request backend resp, then show to users.

gl.GfmAutoComplete.dataSources which is defined in _init_auto_complete.html.haml by calling a helper autocomplete_data_sources.

autocomplete_data_sources requires two arguments: object, noteable_type., noteable_type => noteable.class needs to be defined in controller.

Relevant files

app/assets/javascripts/issuable_form.js
app/helpers/application_helper.rb
app/views/layouts/_init_auto_complete.html.haml

Relevant commit: https://gitlab.com/gitlab-org/gitlab-ce/commit/5c2078838bb9de710f9025513c4b6ec664bba313

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

User could not mention other members when they editing merge request.

Screenshots (if relevant)

image

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Edited by WayJam So

Merge request reports