Skip to content

Route path lookups through legacy_disk_path

Jacob Vosmaer requested to merge mark-legacy-git-access into master

What does this MR do?

Gain more control over how git repository paths are accessed, with the goal of banning git repository access from production code.

We do this by forcefully injecting the new GitalyClient::StorageSettings class and only making the real 'path' value accessible via the new 'legacy_disk_path' accessor. The idea is that this gives us something to grep for in the code, and a place where we can do things like conditionally raising an exception.

Although I looked hard, there is a good chance that this MR breaks something. All I had to go on was grepping for the word 'path' and the test suite.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Edited by Jacob Vosmaer

Merge request reports