Skip to content

Fix filtering projects & groups on group pages

Bob Van Landuyt requested to merge bvl-parent-preloading into master

What does this MR do?

This fixes 3 bugs when displaying group pages:

  • On the group-dashboard & group-explore pages: Previously the filter was applied when loading ancestors, which means ancestors that would not match the filter were not loaded. This caused an exception when expanding the hierarchy for the search result.
    Now we are selecting the groups to load the ancestors of based on the ID of the matched groups.

  • On the group-show-page we would also showed projects shared with the group. These should not be loaded there, only projects that are actual descendants of the group.

  • On that show page when filtering, we also excluded some ancestors of matched subgroups if they didn't fit the pagination. Now all ancestors are loaded regardless of the pagination. This means that per matched record a maximum of 24 more groups might be present in the collection.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/40785

Edited by Toon Claes

Merge request reports