Skip to content

Fix commit message in non-UTF-8 encoding may be shown corrupted.

What does this MR do?

Fix commit message in non-UTF-8 encoding may be shown corrupted.

Are there points in the code the reviewer needs to double check?

no

Why was this MR needed?

It fixes UI bug.

Screenshots (if relevant)

Issue

Снимок_экрана_от_2017-11-06_00-46-35

Снимок_экрана_от_2017-11-06_00-46-48

Снимок_экрана_от_2017-11-06_00-56-40

Снимок_экрана_от_2017-11-06_00-57-43

fixed with this MR issue

Снимок_экрана_от_2017-11-06_01-37-09

Снимок_экрана_от_2017-11-06_01-35-32

Снимок_экрана_от_2017-11-06_01-35-48

Снимок_экрана_от_2017-11-06_01-35-56

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

#39819 (moved)

P.S. Tests fail, but I don't see anything related with the change made in this patch (And I'm not sure that tests passed BEFORE this patch). Besides, I've rebased [this patch onto v10.1.1] (https://gitlab.com/ashumkin/gitlab-ce/tree/commit-message-encoding-against-10.1.1) and have run tests on that commit and there were related to EE and timeout failures. This makes me think I haven't break anything

Edited by Alexey Shumkin

Merge request reports