Resolve "Projects::MergeRequestsController#show is slow (implement skeleton loading)"
What does this MR do?
on-demand clientside loading of MR Dicussion diffs
Are there points in the code the reviewer needs to double check?
- other usages of _diff_with_notes template (potentially any usage of discussions/discussion.html)
- probably a better place for this to live than toggle_behavior.js
Why was this MR needed?
Controller#show was slow
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Review
-
Has been reviewed by UX -
Has been reviewed by Frontend -
Has been reviewed by Backend -
Has been reviewed by Database
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Squashed related commits together
What are the relevant issue numbers?
Closes #35475 (closed)
Edited by Simon Knox